Skip to content

[CI] Add a github action linter.#20561

Merged
hageboeck merged 1 commit intoroot-project:masterfrom
hageboeck:actionlint
Nov 28, 2025
Merged

[CI] Add a github action linter.#20561
hageboeck merged 1 commit intoroot-project:masterfrom
hageboeck:actionlint

Conversation

@hageboeck
Copy link
Copy Markdown
Member

@hageboeck hageboeck commented Nov 28, 2025

The linter checks all action configs in the .github/workflows folder.

Given that we have some work to do, it's for now set to fail-on-error: false. The step will pass, but generate warnings.

@hageboeck hageboeck self-assigned this Nov 28, 2025
@hageboeck hageboeck added the skip ci Skip the full builds on the actions runners label Nov 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 28, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ce547a3.

♻️ This comment has been updated with latest results.

@hageboeck hageboeck force-pushed the actionlint branch 8 times, most recently from debb6ed to cd20154 Compare November 28, 2025 10:38
The linter checks all action configs in the .github/workflows folder.
@hageboeck hageboeck marked this pull request as ready for review November 28, 2025 10:44
@hageboeck hageboeck requested a review from dpiparo as a code owner November 28, 2025 10:44
@hageboeck hageboeck requested a review from guitargeek November 28, 2025 11:18
@hageboeck hageboeck merged commit 043327d into root-project:master Nov 28, 2025
12 checks passed
@hageboeck hageboeck deleted the actionlint branch November 28, 2025 13:26
- name: actionlint
uses: raven-actions/actionlint@v2
with:
files: '.github/workflows/*.yml'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that ends up also testing the included yml files (i.e. the one in subdirectories)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcanal, no, when these files were included, there were a lot more errors. I was busy enough with the top-level folder. 🙂
I suggest we progressively extend the coverage once we touch the subdirectories.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Consider adding a comment though, to clarify that the omission is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip ci Skip the full builds on the actions runners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants