[runtime-cxxmodules] Generate std_darwin.modulemap from active SDK#18235
[runtime-cxxmodules] Generate std_darwin.modulemap from active SDK#18235devajithvs merged 1 commit intoroot-project:masterfrom
Conversation
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
99d0f91 to
ce8f69f
Compare
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
ce8f69f to
9c90a47
Compare
devajithvs
changed the title
Test Results 18 files 18 suites 3d 5h 40m 43s ⏱️ Results for commit b377095. ♻️ This comment has been updated with latest results. |
devajithvs
force-pushed
the
dev.fix_modulemap
branch
4 times, most recently
from
725ea28 to
8dbc8fd
Compare
|
@vgvassilev @hahnjo I was wondering if we should still consider this approach or try to find a different solution. |
|
I would still like to see an automatic solution because at least that gives us a chance that a changed modulemap in an SDK release will work automatically, while currently it is almost guaranteed to break (because of private headers) and we need to rush to fix it and then maintain multiple versions. This is a no-risk improvement over the current situation because if nothing changes in the SDK, the script will just generate the same modifications every time. |
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
This makes a lot of sense, some suggestions inline
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
8dbc8fd to
91a2d8a
Compare
Dynamically extract and wrap the system modulemap from the active SDK in a top-level 'std' module Also remove 'std_ctype_h' module to break cyclic dependencies.
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
91a2d8a to
9ed30eb
Compare
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
LGTM! We can probably get rid of std_darwin.MacOSX14.2.sdk.modulemap as well as we dropped support for mac13 a while ago...
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
b377095 to
9ed30eb
Compare
2 participants
This Pull request:
Dynamically extract and wrap the system modulemap from the active
SDK in a top-level 'std' module
Also remove 'std_ctype_h' module to break cyclic dependencies.
Fixes #18213 for good, in a potentially future proof way.
Changes or fixes:
Checklist:
This PR fixes #