[hist] allow specifying the floating point precision in GetExpFormula#18194
Merged
dpiparo merged 4 commits intoroot-project:masterfrom Mar 30, 2025
Merged
[hist] allow specifying the floating point precision in GetExpFormula#18194dpiparo merged 4 commits intoroot-project:masterfrom
dpiparo merged 4 commits intoroot-project:masterfrom
Conversation
Test Results 18 files 18 suites 5d 2h 0m 29s ⏱️ For more details on these failures, see this check. Results for commit da0880e. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Mar 30, 2025
[skip-ci] improve docu
guitargeek
reviewed
Apr 1, 2025
| virtual Int_t GetNpar() const {return fNpar;} | ||
| virtual Int_t GetNumber() const {return fNumber;} | ||
| virtual TString GetExpFormula(Option_t *option="") const; | ||
| virtual TString GetExpFormula(Option_t *option = "", const char *fl_format = "%g") const; |
Contributor
There was a problem hiding this comment.
The legacy TFormula class should not be changed anymore. Also, the signature of a virtual function should not be changed lightly, because people might override it, and if the signature doesn't match the override is ineffective. And if they don't use the override keyword to hint to the compiler that it should be an override, they won't even get an error or warning!
1 task
2 tasks
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Aug 24, 2025
In root-project#18194, an optional parameter to `TFormula::GetExpFormula()` was introduced, which can be used to customize the precision when putting parameters into the jitted code. However, I don't see the reason why wouldn't like to always print the floating point numbers with maximum precision, which is suggested in this commit. This is achieved using modern C++ functions, which are also not respecting the users locale setting, but instead use the classic C locale by default, which is what we need when generating code. Follows up on root-project#18194 (and its partial revert root-project#18216). Closes root-project#17225. Replaces root-project#17327.
guitargeek
added a commit
that referenced
this pull request
Aug 26, 2025
In #18194, an optional parameter to `TFormula::GetExpFormula()` was introduced, which can be used to customize the precision when putting parameters into the jitted code. However, I don't see the reason why wouldn't like to always print the floating point numbers with maximum precision, which is suggested in this commit. This is achieved using modern C++ functions, which are also not respecting the users locale setting, but instead use the classic C locale by default, which is what we need when generating code. Follows up on #18194 (and its partial revert #18216). Closes #17225. Replaces #17327.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #10769
Checklist: