[ntuple] Implement Detail::RRawPtrWriteEntry#18049
Merged
hahnjo merged 6 commits intoroot-project:masterfrom Apr 4, 2025
Merged
[ntuple] Implement Detail::RRawPtrWriteEntry#18049hahnjo merged 6 commits intoroot-project:masterfrom
Detail::RRawPtrWriteEntry#18049hahnjo merged 6 commits intoroot-project:masterfrom
Conversation
hahnjo
requested review from
bellenot,
couet,
dpiparo and
vepadulano
as code owners
hahnjo
commented
Mar 19, 2025
Test Results 18 files 18 suites 4d 10h 34m 28s ⏱️ For more details on these failures, see this check. Results for commit b461491. ♻️ This comment has been updated with latest results. |
hahnjo
force-pushed
the
ntuple-RRawPtrWriteEntry
branch
from
437cc7b to
7b1d766
Compare
hahnjo
force-pushed
the
ntuple-RRawPtrWriteEntry
branch
from
7b1d766 to
3d3a4ee
Compare
hahnjo
force-pushed
the
ntuple-RRawPtrWriteEntry
branch
from
3d3a4ee to
a4291b1
Compare
enirolf
approved these changes
Apr 3, 2025
Contributor
enirolf
left a comment
enirolf
left a comment
There was a problem hiding this comment.
LGTM! I added two minor documentation-related comments but otherwise good to go.
RNTupleReader::CreateEntry() needs to call GetModel(), which is not const.
It will also be used by RRawPtrWriteEntry.
... to avoid code duplication when adding RRawPtrWriteEntry.
It is a container of const raw pointers that can be used to write constant data products in frameworks. Closes root-project#17900
hahnjo
force-pushed
the
ntuple-RRawPtrWriteEntry
branch
from
a4291b1 to
b461491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a container of
constraw pointers that can be used to write constant data products in frameworks.Closes #17900