[cmake] Build clad with one core only#16682
Merged
dpiparo merged 1 commit intoroot-project:masterfrom Oct 16, 2024
Merged
Conversation
Test Results 17 files 17 suites 3d 23h 55m 6s ⏱️ For more details on these failures, see this check. Results for commit 78a3ce0. |
bellenot
approved these changes
Oct 15, 2024
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Mar 4, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on root-project#16682.
guitargeek
added a commit
that referenced
this pull request
Mar 4, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on #16682.
enirolf
pushed a commit
to enirolf/root
that referenced
this pull request
Mar 10, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on root-project#16682.
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Mar 12, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on root-project#16682.
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Mar 12, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on root-project#16682.
guitargeek
added a commit
that referenced
this pull request
Mar 13, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on #16682.
guitargeek
added a commit
that referenced
this pull request
Mar 13, 2025
The problem around for which the added `-j 1` was a workaround was reported and solved upstream in CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/26398 It's better to not do the workaround for the fixed CMake versions anymore, because actually the increase in build time can be quite significant. On my machine, building ROOT `master` with a warm ccache takes 5m33s with 32 threads, which reduces to 4m6s without the workaround. Follows up on #16682.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16654
See also #16667 that on top of these changes adds a Ubuntu 24.10 build.