Skip to content

Update ROOT's R interface for Rcpp 1.0.13#16075

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
ellert:Rcpp-1.0.13
Jul 22, 2024
Merged

Update ROOT's R interface for Rcpp 1.0.13#16075
guitargeek merged 1 commit intoroot-project:masterfrom
ellert:Rcpp-1.0.13

Conversation

@ellert
Copy link
Copy Markdown
Contributor

@ellert ellert commented Jul 21, 2024

This Pull request:

Changes or fixes:

From the Rcpp changelog:

  • inst/include/Rcpp/: Added variadic templates to be used instead of
    the generated code in Rcpp/generated and Rcpp/module when
    compiling with C++11 or later.

This PR adapts ROOT's R interface code to this change,

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ellert ellert requested a review from dpiparo as a code owner July 21, 2024 21:26
@guitargeek guitargeek self-assigned this Jul 22, 2024
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@guitargeek guitargeek merged commit 35dc952 into root-project:master Jul 22, 2024
@ellert ellert deleted the Rcpp-1.0.13 branch July 22, 2024 11:04
@stephanlachnit
Copy link
Copy Markdown
Contributor

Any chance this can be backported to the 6.32 series?

@guitargeek
Copy link
Copy Markdown
Contributor

It is already backported and will be part of 6.32.04, which will be released next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants