io: Avoid infinite recursion in TFile::Open#15591
Merged
pcanal merged 1 commit intoroot-project:masterfrom May 23, 2024
Merged
Conversation
Test Results 10 files 10 suites 2d 4h 0m 4s ⏱️ Results for commit ddecc0d. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
May 22, 2024
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for this fix.
Member
|
How about a test so if we change the function again we don't forget about this use case ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #15590