Skip to content

[TMVA] Enable again all tests on alma9 and fedora39#15439

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:flexiblas
May 8, 2024
Merged

[TMVA] Enable again all tests on alma9 and fedora39#15439
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:flexiblas

Conversation

@guitargeek
Copy link
Copy Markdown
Contributor

Now that we're using a system-compatible version of NumPy on the CI images for these platforms, the TMVA tests should all pass again.

@guitargeek guitargeek self-assigned this May 7, 2024
Now that we're using a system-compatible version of NumPy on the CI
images for these platforms, the TMVA tests should all pass again.
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2024

Test Results

    10 files      10 suites   2d 3h 25m 23s ⏱️
 2 635 tests  2 629 ✅ 0 💤 6 ❌
24 857 runs  24 851 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 24679a2.

@lmoneta
Copy link
Copy Markdown
Member

lmoneta commented May 8, 2024

Thank you Jonas for fixing this problem!

@guitargeek guitargeek merged commit 190ca19 into root-project:master May 8, 2024
@guitargeek guitargeek deleted the flexiblas branch May 8, 2024 12:40
builtin_vdt=On
tmva-sofie=On
tmva-cpu=OFF
BLA_VENDOR=OpenBLAS
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this option doing? If it exists, shouldn't it be BLAS_VENDOR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a funny name, yes :D But that's how it is:
https://cmake.org/cmake/help/latest/module/FindBLAS.html#input-variables

It forces the use of openblas instead of flexiblas. More context here:
#15309 (comment)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new default blas in alma9 (flexiblas) can't be used simultaneously with the openblas that is builtin to NumPy. But using OpenBlas is also a good configuration, since this is also what the LCG packages use I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants