[core/zip+lzma] Properly account for header size [v6.26]#14626
Merged
hahnjo merged 4 commits intoroot-project:v6-26-00-patchesfrom Feb 8, 2024
Merged
[core/zip+lzma] Properly account for header size [v6.26]#14626hahnjo merged 4 commits intoroot-project:v6-26-00-patchesfrom
hahnjo merged 4 commits intoroot-project:v6-26-00-patchesfrom
Conversation
R__unzipZLIB is already properly subtracting it from srcsize. (cherry picked from commit 44d1c23)
lzma_code must only see the buffers without the header, so the sizes have to be adjusted accordingly. Fixes root-project#14508 (cherry picked from commit 17e3561)
In practice, the target size is greater or equal the source size in most cases for ROOT, but add this additional correct check to fuzz the inputs in the next commit. (cherry picked from commit 23261a6)
This would have found any of the previous three commits. (cherry picked from commit 73d8c3d)
hahnjo
requested review from
Axel-Naumann,
bellenot and
pcanal
as code owners
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Warnings:
|
|
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests:
|
|
Build failed on mac12arm/cxx20. Errors:
And 5 more Warnings:
And 303 more |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Member
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compression algorithms only see the buffers without the header, so the sizes have to be adjusted accordingly.
Fixes #14508, backport of #14523