Skip to content

Add missing import to TMVA pythonizations#11490

Merged
Axel-Naumann merged 1 commit intoroot-project:masterfrom
hahnjo:fix-python
Oct 4, 2022
Merged

Add missing import to TMVA pythonizations#11490
Axel-Naumann merged 1 commit intoroot-project:masterfrom
hahnjo:fix-python

Conversation

@hahnjo
Copy link
Copy Markdown
Member

@hahnjo hahnjo commented Oct 4, 2022

This should fix the breakage seen across all platforms.

This should fix the breakage seen across all platforms.
@hahnjo hahnjo requested a review from lmoneta October 4, 2022 11:33
@hahnjo hahnjo self-assigned this Oct 4, 2022
@hahnjo hahnjo requested a review from etejedor as a code owner October 4, 2022 11:33
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

Copy link
Copy Markdown
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Axel-Naumann
Copy link
Copy Markdown
Member

Many builds are happier than before - let's merge and not waste any more time with completely broken PyROOT... Thank you for fixing this, @hahnjo . FYI, @lmoneta

@Axel-Naumann Axel-Naumann merged commit 0563e24 into root-project:master Oct 4, 2022
@hahnjo hahnjo deleted the fix-python branch October 4, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants