Force storing of StreamerInfo for nested non-split but memberwise streamed collection. by pcanal · Pull Request #11446 · root-project/root

pcanal · 2022-09-27T18:20:45Z

This fix #11436

Corresponding roottest PR: root-project/roottest#906

phsft-bot · 2022-09-27T18:20:51Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-27T18:21:32Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-28T01:12:32Z

Build failed on mac1015/cxx17.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-28T03:44:05Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

Axel-Naumann

Just making sure you saw the crucial functional change that seems required...

Axel-Naumann · 2022-09-28T06:13:32Z

io/io/src/TStreamerInfo.cxx

+      TClass *valueClass = fClass->GetCollectionProxy()->GetValueClass();
+      if (false && valueClass)


Suggested change

TClass *valueClass = fClass->GetCollectionProxy()->GetValueClass();

if (false && valueClass)

if (TClass *valueClass = fClass->GetCollectionProxy()->GetValueClass())

…eamed collection. This fix root-project#11436

phsft-bot · 2022-09-29T10:27:42Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-29T10:27:58Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-09-29T10:27:57.252Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:584:

phsft-bot · 2022-09-29T10:29:41Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-29T10:29:40.319Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:584:

phsft-bot · 2022-09-29T10:29:44Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-29T10:29:43.109Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:584:

phsft-bot · 2022-09-29T10:29:45Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-29T10:29:43.658Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:584:

phsft-bot · 2022-09-29T10:29:46Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-29T10:29:45.175Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:584:

phsft-bot · 2022-09-29T10:29:59Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-29T10:29:57.841Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:584:

pcanal · 2022-09-29T11:39:22Z

@phsft-bot build

phsft-bot · 2022-09-29T11:39:28Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-29T12:06:04Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.genreflex.ROOT-5881.roottest_root_meta_genreflex_ROOT_5881_execStringInputFiles

phsft-bot · 2022-09-29T12:09:59Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-09-29T11:48:18.356Z] tmva/sofie/test/Shape_FromONNX.hxx:20:35: warning: unused parameter ‘tensor_X’ [-Wunused-parameter]

Failing tests:

projectroot.roottest.root.meta.genreflex.ROOT-5881.roottest_root_meta_genreflex_ROOT_5881_execStringInputFiles

phsft-bot · 2022-09-29T12:13:36Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-09-29T11:48:32.734Z] /mnt/build/workspace/root-pullrequests-build/build/tmva/sofie/test/Shape_FromONNX.hxx:20:35: warning: unused parameter ‘tensor_X’ [-Wunused-parameter]

Failing tests:

And 514 more

phsft-bot · 2022-09-29T12:43:24Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-29T12:49:10Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-29T12:59:25Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.genreflex.ROOT-5881.roottest_root_meta_genreflex_ROOT_5881_execStringInputFiles

phsft-bot · 2022-09-29T16:37:56Z

Build failed on mac1015/cxx17.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

pcanal · 2022-10-04T15:46:15Z

All test passes as reported my the related roottest PR: root-project/roottest#906 (comment).

pcanal requested review from Axel-Naumann, bellenot, couet, etejedor, gganis and lmoneta as code owners September 27, 2022 18:20

pcanal requested review from jblomer and removed request for Axel-Naumann September 27, 2022 18:20

pcanal force-pushed the master-11436 branch from 023e517 to a5ee115 Compare September 27, 2022 18:21

pcanal requested review from Axel-Naumann and removed request for bellenot, couet, etejedor, gganis and lmoneta September 27, 2022 18:22

pcanal self-assigned this Sep 28, 2022

Axel-Naumann requested changes Sep 28, 2022

View reviewed changes

Force storing of StreamerInfo for nested non-split but memberwise str…

4b71281

…eamed collection. This fix root-project#11436

pcanal force-pushed the master-11436 branch from a5ee115 to 4b71281 Compare September 29, 2022 10:27

pcanal merged commit 9d61639 into root-project:master Oct 4, 2022

pcanal deleted the master-11436 branch October 4, 2022 15:46

pcanal mentioned this pull request Apr 3, 2023

Replay failures after #41198 introduced cms-sw/cmssw#41246

Closed

		TClass *valueClass = fClass->GetCollectionProxy()->GetValueClass();
		if (false && valueClass)

	TClass *valueClass = fClass->GetCollectionProxy()->GetValueClass();
	if (false && valueClass)
	if (TClass *valueClass = fClass->GetCollectionProxy()->GetValueClass())

Conversation

pcanal commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Sep 27, 2022

Uh oh!

phsft-bot commented Sep 27, 2022

Uh oh!

phsft-bot commented Sep 28, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 28, 2022

Failing tests:

Uh oh!

Axel-Naumann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann Sep 28, 2022

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Sep 29, 2022

Uh oh!

phsft-bot commented Sep 29, 2022

Errors:

Uh oh!

phsft-bot commented Sep 29, 2022

Errors:

Uh oh!

phsft-bot commented Sep 29, 2022

Errors:

Uh oh!

phsft-bot commented Sep 29, 2022

Errors:

Uh oh!

phsft-bot commented Sep 29, 2022

Errors:

Uh oh!

phsft-bot commented Sep 29, 2022

Errors:

Uh oh!

pcanal commented Sep 29, 2022

Uh oh!

phsft-bot commented Sep 29, 2022

Uh oh!

phsft-bot commented Sep 29, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 29, 2022

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 29, 2022

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 29, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 29, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 29, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 29, 2022

Uh oh!

pcanal commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pcanal commented Sep 27, 2022 •

edited

Loading

Axel-Naumann left a comment •

edited

Loading