[cmake] Protect against empty COMPILE_DEFINITIONS in genreflex command#11408
Merged
pcanal merged 1 commit intoroot-project:masterfrom Sep 26, 2022
Merged
[cmake] Protect against empty COMPILE_DEFINITIONS in genreflex command#11408pcanal merged 1 commit intoroot-project:masterfrom
pcanal merged 1 commit intoroot-project:masterfrom
Conversation
This applies the change made to ROOT_GENERATE_DICTIONARY in the main branch commit 08ab7e0 to GENREFLEX_GENERATE_DICTIONARY. This commit in conjunction with 08ab7e0 fixes root-project#11312. See commit 08ab7e0 and issue root-project#11312 for more details on the issue and solution.
|
Starting build on |
|
Build failed on windows10/cxx14. Failing tests:
|
Member
Author
|
@phsft-bot build |
|
Starting build on |
Axel-Naumann
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the change made to ROOT_GENERATE_DICTIONARY in the main branch commit 08ab7e0 to GENREFLEX_GENERATE_DICTIONARY.
This commit in conjunction with 08ab7e0 fixes #11312.
See commit 08ab7e0 and issue #11312 for more details on the issue and solution.