[hist] Fix in THnBase::Add the computation of the running sums by lmoneta · Pull Request #11407 · root-project/root

lmoneta · 2022-09-21T15:50:13Z

The sum of weight, weight square and weigth * x used for statistics computation where not update when adding/merging THnBase classes.

This fixes #11333

The sum of weight, weight square and weigth * x used for statistics computation where not update when adding/merging THnBase classes. This fixes root-project#11333

phsft-bot · 2022-09-21T15:50:19Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-21T16:20:30Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-09-21T16:15:06.012Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/Support/Casting.h(393,28): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\IPO\WholeProgramDevirt.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\IPO\LLVMipo.vcxproj]
[2022-09-21T16:15:07.387Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/IR/IntrinsicInst.h(156,11): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Utils\LowerMemIntrinsics.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Utils\LLVMTransformUtils.vcxproj]
[2022-09-21T16:15:07.387Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/Support/PointerLikeTypeTraits.h(96,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\CodeGen\SelectionDAG\SelectionDAGAddressAnalysis.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\CodeGen\SelectionDAG\LLVMSelectionDAG.vcxproj]
[2022-09-21T16:15:07.387Z] c1xx : fatal error C1060: compiler is out of heap space [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Scalar\LLVMScalarOpts.vcxproj]
[2022-09-21T16:15:07.645Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/Support/PointerLikeTypeTraits.h(84,57): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Target\NVPTX\NVPTXPrologEpilogPass.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Target\NVPTX\LLVMNVPTXCodeGen.vcxproj]
[2022-09-21T16:15:10.022Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Scalar\PartiallyInlineLibCalls.cpp(186,1): fatal error C1060: compiler is out of heap space [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Scalar\LLVMScalarOpts.vcxproj]
[2022-09-21T16:15:10.022Z] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\vector(56,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\CodeGen\SelectionDAG\SelectionDAG.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\CodeGen\SelectionDAG\LLVMSelectionDAG.vcxproj]
[2022-09-21T16:15:10.022Z] cl : command line error D8027: C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Target\NVPTX\NVPTXGenericToNVVM.cpp : fatal error C1001: Internal compiler error. [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Target\NVPTX\LLVMNVPTXCodeGen.vcxproj]
[2022-09-21T16:15:10.022Z] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\utility(211,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Scalar\NewGVN.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Scalar\LLVMScalarOpts.vcxproj]
[2022-09-21T16:15:10.022Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/InitializePasses.h(162,54): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\AST\APValue.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\AST\obj.clangAST.vcxproj]

And 55 more

phsft-bot · 2022-09-21T16:20:32Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

phsft-bot · 2022-09-21T16:22:34Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

phsft-bot · 2022-09-21T16:33:57Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

phsft-bot · 2022-09-21T16:44:54Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

Axel-Naumann

❤️ thank you!

phsft-bot · 2022-09-21T18:50:54Z

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-22T00:19:48Z

Build failed on mac1015/cxx17.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

In THnBase::Init the dimension of the THnBase histogram was changed but the size of the contained arrays needs to be changed as well.

phsft-bot · 2022-09-22T08:04:47Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-22T08:33:09Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

phsft-bot · 2022-09-22T08:38:48Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

phsft-bot · 2022-09-22T08:42:57Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.hist.roottest_root_hist_assertSparseToTHn

…and fTsumwx2 arrays with correct size

phsft-bot · 2022-09-22T09:09:56Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-22T09:34:59Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-09-22T09:34:57.924Z] LINK : fatal error LNK1104: cannot open file 'C:\build\workspace\root-pullrequests-build\build\bin\libCore.dll' [C:\build\workspace\root-pullrequests-build\build\core\Core.vcxproj]

phsft-bot · 2022-09-22T10:39:59Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.distrdf.common.roottest_python_distrdf_common_test_all

[hist] Fix in THnBase::Add the computation of the running sum

bf86d1b

The sum of weight, weight square and weigth * x used for statistics computation where not update when adding/merging THnBase classes. This fixes root-project#11333

lmoneta requested a review from Axel-Naumann September 21, 2022 15:50

lmoneta self-assigned this Sep 21, 2022

Fuse Conv or ConvTranspose and Add

0d3cd8a

Axel-Naumann approved these changes Sep 21, 2022

View reviewed changes

[hist] Resize array of sumwx and sumwx2 in THnBase::Init

649cf44

In THnBase::Init the dimension of the THnBase histogram was changed but the size of the contained arrays needs to be changed as well.

lmoneta requested a review from sitongan as a code owner September 22, 2022 08:04

[hist] Add protection in case histogram to add does not have fTsumwx …

bd31c26

…and fTsumwx2 arrays with correct size

lmoneta merged commit 854075b into root-project:master Sep 22, 2022

lmoneta mentioned this pull request Sep 23, 2022

[hist] Backport in 6.26 some fixes in hist #11426

Merged

kpedro88 added a commit to kpedro88/root that referenced this pull request Sep 23, 2022

backport root-project#11407

ac9a89f

Conversation

lmoneta commented Sep 21, 2022

Uh oh!

phsft-bot commented Sep 21, 2022

Uh oh!

phsft-bot commented Sep 21, 2022

Errors:

Uh oh!

phsft-bot commented Sep 21, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 21, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 21, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 21, 2022

Failing tests:

Uh oh!

Axel-Naumann left a comment

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Sep 21, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 22, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 22, 2022

Uh oh!

phsft-bot commented Sep 22, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 22, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 22, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 22, 2022

Uh oh!

phsft-bot commented Sep 22, 2022

Errors:

Uh oh!

phsft-bot commented Sep 22, 2022

Failing tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants