core: Disable check for already deleted object. by pcanal · Pull Request #11334 · root-project/root

pcanal · 2022-09-08T21:53:44Z

On some platform operator delete taints the memory, so even right after the deletion the information stored by ~TObject is already erased. On those platform we no longer rely on the kNotDelete bit hack and rely on the system (which has tainted the memory assumingly for a reason) to detect the use-after-delete problems.

Introduce 2 new functions.

TObject::IsDestructed (used by TClonesArray) that detects that the destructor has been run and is active in all configuration. This should be used if the code knows that the memory has not been freed/deleted.

ROOT::Detail::HasBeenDeleted(TObject*) with returns true if the platform does not taint the memory and if the kNotDeleted is not set (in all other case, it returns false)

This fixes #11330

phsft-bot · 2022-09-08T21:53:51Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-08T22:07:30Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

phsft-bot · 2022-09-08T22:28:15Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

phsft-bot · 2022-09-08T23:08:24Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-08T23:17:05Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

phsft-bot · 2022-09-08T23:43:06Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

phsft-bot · 2022-09-09T00:18:43Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-09T00:33:15Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-09T00:51:44Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-09T01:20:14Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-09T01:54:29Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-09T01:55:11Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-09-09T01:51:17.373Z] C:\build\workspace\root-pullrequests-build\build\bin\libNet.dll : fatal error LNK1120: 1 unresolved externals [C:\build\workspace\root-pullrequests-build\build\net\net\Net.vcxproj]
[2022-09-09T01:55:10.720Z] C:\build\workspace\root-pullrequests-build\build\bin\libHist.dll : fatal error LNK1120: 1 unresolved externals [C:\build\workspace\root-pullrequests-build\build\hist\hist\Hist.vcxproj]

Axel-Naumann

Let's talk :-)

core/base/inc/TObject.h

core/base/src/TObject.cxx

phsft-bot · 2022-09-13T19:19:54Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

pcanal · 2022-09-13T19:20:28Z

The code was updated to replace the MockTObject with friendship.

phsft-bot · 2022-09-13T19:20:57Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-13T19:20:49.937Z] stderr: error: Failed to merge in the changes.
[2022-09-13T19:20:56.504Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-09-13T19:21:00Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-13T19:21:00.004Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-09-13T19:21:07Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-13T19:21:01.447Z] stderr: error: Failed to merge in the changes.
[2022-09-13T19:21:06.119Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-09-13T19:21:08Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-09-13T19:20:58.541Z] stderr: error: Failed to merge in the changes.
[2022-09-13T19:21:06.414Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-09-13T19:21:24Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-09-13T19:21:02.003Z] stderr: error: Failed to merge in the changes.
[2022-09-13T19:21:23.927Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-09-13T19:22:51Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-13T20:15:49Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-09-13T23:26:26Z

Build failed on mac1015/cxx17.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Axel-Naumann

But see comments

core/base/inc/TObject.h

core/base/src/TObject.cxx

core/cont/src/TClonesArray.cxx

phsft-bot · 2022-09-20T18:49:01Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-20T21:31:20Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-09-20T20:36:35.738Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
[2022-09-20T20:36:35.738Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
[2022-09-20T20:36:35.738Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
[2022-09-20T20:36:35.738Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]

Failing tests:

phsft-bot · 2022-09-21T04:41:37Z

Build failed on mac1015/cxx17.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-09-21T03:34:25.893Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
[2022-09-21T03:34:25.894Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
[2022-09-21T03:34:25.894Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
[2022-09-21T03:34:25.894Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]

pcanal · 2022-09-21T14:35:25Z

@phsft-bot build

phsft-bot · 2022-09-21T14:35:32Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

On some platform operator delete taints the memory, so even right after the deletion the information stored by ~TObject is already erased. On those platform we no longer rely on the kNotDelete bit hack and rely on the system (which has tainted the memory assumingly for a reason) to detect the use-after-delete problems. Introduce 2 new functions. TObject::IsDestructed (used by TClonesArray) that detects that the destructor has been run and is active in all configuration. This should be used if the code knows that the memory has not been freed/deleted. ROOT::Detail::HasBeenDeleted(TObject*) with returns true if the platform does not taint the memory and if the kNotDeleted is not set (in all other case, it returns false) This fixes root-project#11330

phsft-bot · 2022-09-21T14:44:28Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2022-09-21T16:04:11Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-09-21T15:16:22.573Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
[2022-09-21T15:16:22.573Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
[2022-09-21T15:16:22.573Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
[2022-09-21T15:16:22.573Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]

phsft-bot · 2022-09-21T16:19:21Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

pcanal · 2022-09-22T21:41:54Z

@phsft-bot build

phsft-bot · 2022-09-22T21:42:00Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

pcanal requested review from Axel-Naumann, bellenot, couet, gganis and lmoneta as code owners September 8, 2022 21:53

pcanal force-pushed the master-11330 branch from 4754632 to a0e5490 Compare September 8, 2022 23:08

pcanal changed the title ~~core: Disable test for already deleted object.~~ core: Disable check for already deleted object. Sep 9, 2022

pcanal force-pushed the master-11330 branch from a0e5490 to d90ff53 Compare September 9, 2022 00:18

pcanal force-pushed the master-11330 branch from d90ff53 to 54b8ab6 Compare September 9, 2022 00:33

pcanal force-pushed the master-11330 branch from 54b8ab6 to 308abe7 Compare September 9, 2022 00:51

root-project deleted a comment from phsft-bot Sep 9, 2022

Axel-Naumann reviewed Sep 13, 2022

View reviewed changes

pcanal force-pushed the master-11330 branch from a5910e3 to d4b3039 Compare September 13, 2022 19:22

pcanal requested a review from Axel-Naumann September 15, 2022 17:53

Axel-Naumann approved these changes Sep 20, 2022

View reviewed changes

pcanal force-pushed the master-11330 branch from 134b1a8 to e6d30b0 Compare September 21, 2022 14:44

pcanal mentioned this pull request Sep 21, 2022

v626 core: Disable test for already deleted object. #11405

Merged

eguiraud removed their request for review September 27, 2022 14:48

pcanal merged commit 94a44fe into root-project:master Sep 28, 2022

pcanal deleted the master-11330 branch September 28, 2022 01:00

Conversation

pcanal commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 8, 2022

Uh oh!

phsft-bot commented Sep 9, 2022

Uh oh!

phsft-bot commented Sep 9, 2022

Uh oh!

phsft-bot commented Sep 9, 2022

Uh oh!

phsft-bot commented Sep 9, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 9, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 9, 2022

Errors:

Uh oh!

Axel-Naumann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Sep 13, 2022

Uh oh!

pcanal commented Sep 13, 2022

Uh oh!

phsft-bot commented Sep 13, 2022

Errors:

Uh oh!

phsft-bot commented Sep 13, 2022

Errors:

Uh oh!

phsft-bot commented Sep 13, 2022

Errors:

Uh oh!

phsft-bot commented Sep 13, 2022

Errors:

Uh oh!

phsft-bot commented Sep 13, 2022

Errors:

Uh oh!

phsft-bot commented Sep 13, 2022

Uh oh!

phsft-bot commented Sep 13, 2022

Failing tests:

Uh oh!

phsft-bot commented Sep 13, 2022

Failing tests:

Uh oh!

Axel-Naumann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!