[DF] Fix potential use-after-delete in sample callbacks #11251
Merged
eguiraud merged 2 commits intoroot-project:masterfrom Aug 25, 2022
Merged
[DF] Fix potential use-after-delete in sample callbacks #11251eguiraud merged 2 commits intoroot-project:masterfrom
eguiraud merged 2 commits intoroot-project:masterfrom
Conversation
Before this commit, if an action with a sample callback (currently only Snapshot) or a DefinePerSample went out of scope, we did not deregister the corresponding callbacks from the RLoopManager, which would try to run them anyway during the following event loop. As callbacks typically perform a call on the original action or define objects, this could cause a use-after-delete. With this patch, we now associate each callback to the address of the corresponding node of the computation graph and remove callbacks when the nodes go out of scope. This fixes root-project#11222.
|
Starting build on |
vepadulano
approved these changes
Aug 25, 2022
|
Build failed on mac1015/cxx17. Failing tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, if an action with a sample callback (currently
only Snapshot) or a DefinePerSample went out of scope, we did not
deregister the corresponding callbacks from the RLoopManager, which
would try to run them anyway during the following event loop.
As callbacks typically perform a call on the original action or
define objects, this could cause a use-after-delete.
With this patch, we now associate each callback to the address of
the corresponding node of the computation graph and remove callbacks
when the nodes go out of scope.
This fixes #11222.