[DF] Fix jitted expressions with sub-branches of aliases#11216
[DF] Fix jitted expressions with sub-branches of aliases#11216eguiraud merged 2 commits intoroot-project:masterfrom
Conversation
|
Starting build on |
eguiraud
force-pushed
the
df-alias-and-subbranch
branch
from
6128eca to
1d5ffc4
Compare
|
Starting build on |
|
Force-pushed a new version of the last commit with the clang-format fixes applied. |
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Generally looks good, maybe just a comment for clarification
Given a string expression such as "alias.subbranch" (where
`subbranch` is _not_ also the name of a valid data member of
the type of the "alias" top-level branch), we used to transform
the expression to `[](T &var0) { return var0.subbranch; }`,
which does not compile.
Now aliases in jitted expressions are resolved in a first step
and only then we try to match the expression against known branch
names, fixing the problem.
This fixes root-project#11207 .
eguiraud
force-pushed
the
df-alias-and-subbranch
branch
from
1d5ffc4 to
8fef266
Compare
|
Starting build on |
|
The patch is exactly the same, I force-pushed a new version of the test that uses a
|
|
Build failed on windows10/cxx14. |
4 participants
Given a string expression such as "alias.subbranch" (where
subbranchis not also the name of a valid data member ofthe type of the "alias" top-level branch), we used to transform
the expression to
[](T &var0) { return var0.subbranch; },which does not compile.
Now aliases in jitted expressions are resolved in a first step
and only then we try to match the expression against known branch
names, fixing the problem.
This PR fixes #11207 (and adds a test).
std::vector<XYZVector>, for which we should have dictionaries