[hist] Fix label merge when one axis is numerical and extendable#11045
Merged
lmoneta merged 1 commit intoroot-project:masterfrom Sep 23, 2022
Merged
[hist] Fix label merge when one axis is numerical and extendable#11045lmoneta merged 1 commit intoroot-project:masterfrom
lmoneta merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on windows10/cxx14. |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
couet
approved these changes
Aug 1, 2022
Create a new type of merging, a special case when histogram has an axis with label and one axis can be merge numerically but are compatible. A new test is added also in stressHIstogram for this new case This should fix ROOT-10828
lmoneta
force-pushed
the
fix_th1_merge_10828
branch
from
6361b14 to
830aa4c
Compare
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new type of merging, a special case when the histogram has an axis with label and the other axis is numeric and different but compatible.
A new test is added also in stressHIstogram for this new case
This fixes #10828