[RF] Skip out-of-range events in RDataFrame to RooDataSet Helper#11018
[RF] Skip out-of-range events in RDataFrame to RooDataSet Helper#11018guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on ROOT-debian10-i386/soversion. Failing tests: |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests:
|
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
The RDataFrameHelper should be consistent with creating a RooDataSet from a TTree, meaning out-of-range events should be skipped. This is implemented in this commit, borrowing the logic from `RooTreeDataStore::loadValues()`. A unit test is also implemented. The previous logic of just taking just all values to fill the dataset was very dangerous, because these values then clipped to the RooRealVar limits and biased the number of events observed at the boundaries. Closes root-project#11017.
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
Build failed on mac11/cxx14. Failing tests: |
|
Build failed on mac1015/cxx17. Failing tests: |
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM !
Thank you for the fix!
3 participants
The RDataFrameHelper should be consistent with creating a RooDataSet
from a TTree, meaning out-of-range events should be skipped. This is
implemented in this commit, borrowing the logic from
RooTreeDataStore::loadValues(). A unit test is also implemented.The previous logic of just taking just all values to fill the dataset
was very dangerous, because these values then clipped to the RooRealVar
limits and biased the number of events observed at the boundaries.
Closes #11017.