Skip to content

[DF] Fix regex substiution in code to jit#11008

Merged
ikabadzhov merged 2 commits intoroot-project:masterfrom
ikabadzhov:rdf-jittedfilters
Jul 21, 2022
Merged

[DF] Fix regex substiution in code to jit#11008
ikabadzhov merged 2 commits intoroot-project:masterfrom
ikabadzhov:rdf-jittedfilters

Conversation

@ikabadzhov
Copy link
Copy Markdown
Contributor

@ikabadzhov ikabadzhov commented Jul 20, 2022

This PR fixes #11002

@ikabadzhov ikabadzhov self-assigned this Jul 20, 2022
@ikabadzhov ikabadzhov requested a review from eguiraud as a code owner July 20, 2022 16:04
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 20, 2022

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 20, 2022

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 20, 2022

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 20, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 20, 2022

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 20, 2022

Build failed on mac1015/cxx17.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

eguiraud
eguiraud suggested changes Jul 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eguiraud eguiraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ivan, a few comments below

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@ikabadzhov ikabadzhov requested a review from eguiraud July 21, 2022 08:36
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

eguiraud
eguiraud approved these changes Jul 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eguiraud eguiraud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @ikabadzhov please also create a backport for v6.26

P.S.
typo in the commit message, "substiution" -> "substitution"

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 21, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@ikabadzhov ikabadzhov merged commit f1014bf into root-project:master Jul 21, 2022
@ikabadzhov ikabadzhov deleted the rdf-jittedfilters branch July 21, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eguiraud eguiraud eguiraud approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ikabadzhov ikabadzhov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DF] Wrong regex substitution when generating code to jit

3 participants

@ikabadzhov @phsft-bot @eguiraud