[cling-cpt] Added skip-cleanup flags for check-requirements and create-dev-env [skip-ci]#10960
Merged
vgvassilev merged 2 commits intoroot-project:masterfrom Jul 17, 2022
Merged
Conversation
This would instruct the cpt to build cling, clang, and llvm, without deleting the build area, as the cpt normally would delete the build area due to the use of memory running out when linking, because of too many build subprocesses.
|
Can one of the admins verify this patch? |
Axel-Naumann
requested review from
vgvassilev
and removed request for
Axel-Naumann
vgvassilev
reviewed
Jul 16, 2022
| tar_required = True | ||
|
|
||
| if args['check_requirements']: | ||
| args['skip_cleanup'] = True |
Member
There was a problem hiding this comment.
Why do we need the skip-cleanup when checking for the requirements?
Contributor
Author
There was a problem hiding this comment.
@vgvassilev my bad I think I misread your email. I assumed you meant add skip-cleanup to the check_requirements flag too.
Member
There was a problem hiding this comment.
Ah, no, only to the other one.
vgvassilev
approved these changes
Jul 17, 2022
vepadulano
pushed a commit
to vepadulano/root
that referenced
this pull request
Jul 20, 2022
…e-dev-env [skip-ci] (root-project#10960) Added skip-cleanup flags for create-dev-env. This would instruct the cpt to build cling, clang, and llvm, without deleting the build area, as the cpt normally would delete the build area due to the use of memory running out when linking, because of too many build subprocesses.
j-mathe
pushed a commit
to j-mathe/root
that referenced
this pull request
Jul 26, 2022
…e-dev-env [skip-ci] (root-project#10960) Added skip-cleanup flags for create-dev-env. This would instruct the cpt to build cling, clang, and llvm, without deleting the build area, as the cpt normally would delete the build area due to the use of memory running out when linking, because of too many build subprocesses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request: Set skip-cleanup flags to true for check-requirements and create-dev-env
Changes or fixes: Set the skip-cleanup value to true for the create-dev-env option and check-requirements option
Checklist:
This PR fixes issue in meta-issue list #406 (root-project/cling#406)