Skip to content

Macos ft brotli off#10770

Merged
bellenot merged 2 commits intoroot-project:masterfrom
FonsRademakers:macos-ft-brotli-off
Jun 21, 2022
Merged

Macos ft brotli off#10770
bellenot merged 2 commits intoroot-project:masterfrom
FonsRademakers:macos-ft-brotli-off

Conversation

@FonsRademakers
Copy link
Copy Markdown
Contributor

This Pull request:

Changes or fixes:

Fixes linking failure with libfreetype on macOS (arm and intel) due to missing brotli library. Brotli support is not needed for the fonts ROOT uses.

Checklist:

  • [x ] tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@FonsRademakers FonsRademakers requested a review from bellenot as a code owner June 16, 2022 09:54
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

Build failed on mac1015/cxx17.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Copy link
Copy Markdown
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bellenot bellenot merged commit 8cd1d74 into root-project:master Jun 21, 2022
bellenot pushed a commit to bellenot/root that referenced this pull request Jun 21, 2022
j-mathe pushed a commit to j-mathe/root that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants