[RF] Consistent behavior for uniform constraint terms in HistFactory#10525
Merged
guitargeek merged 1 commit intoroot-project:masterfrom May 4, 2022
Merged
[RF] Consistent behavior for uniform constraint terms in HistFactory#10525guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
In HistFactory, normalization uncertainties and shape uncertainties were treated differently when setting the constraint type to uniform, e.g.: ```xml <ConstraintTerm Type="Uniform" RelativeUncertainty="1">NP_shape</ConstraintTerm> <ConstraintTerm Type="Uniform" RelativeUncertainty="1">NP_norm</ConstraintTerm> ``` See root-project#9070 for a very good explanation of the problem. For non-shape uncertainties, the uniform constraint was treated as a special case of the Gaussian constraint with "infinite" sigma. For shape uncertainties, the `Uniform` type was ignored. This commit suggests to refactor the creation of Gaussian constraints such that the logic that considers the "Uniform" tag is also used for shape uncertainties. Closes root-project#9070.
|
Starting build on |
1 task
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests:
|
|
Build failed on windows10/cxx14. |
This was referenced May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In HistFactory, normalization uncertainties and shape uncertainties were
treated differently when setting the constraint type to uniform, e.g.:
See #9070 for a very good explanation of the problem.
For non-shape uncertainties, the uniform constraint was treated as a
special case of the Gaussian constraint with "infinite" sigma. For shape
uncertainties, the
Uniformtype was ignored.This commit suggests to refactor the creation of Gaussian constraints
such that the logic that considers the "Uniform" tag is also used for
shape uncertainties.
Closes #9070.