Skip to content

[RF] Ignore categories with no PDF in RooSimultaneous helper code#10495

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:issue-10473
May 2, 2022
Merged

[RF] Ignore categories with no PDF in RooSimultaneous helper code#10495
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:issue-10473

Conversation

@guitargeek
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek commented Apr 29, 2022

A unit test based to check that this is done correctly was also
implemented.

Closes #10473.

@guitargeek guitargeek self-assigned this Apr 29, 2022
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2022

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 30, 2022

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 30, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 1, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@guitargeek
[RF] Ignore categories with no PDF in RooSimultaneous helper code
cc8efa8 
A unit test based to check that this is done correctly was also
implemented.

Closes root-project#10473.
@guitargeek guitargeek mentioned this pull request May 1, 2022
Closed
14 tasks
lmoneta
lmoneta approved these changes May 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for the fix

@guitargeek guitargeek merged commit 6bab632 into root-project:master May 2, 2022
@guitargeek guitargeek deleted the issue-10473 branch May 2, 2022 12:25
@guitargeek guitargeek mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmoneta lmoneta lmoneta approved these changes

@hageboeck hageboeck Awaiting requested review from hageboeck

Assignees

@guitargeek guitargeek

Labels

bug in:RooFit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RF] Crash when RooSimultaneous does not contain a pdf for each value of the index category

3 participants

@guitargeek @phsft-bot @lmoneta