Skip to content

[core] TViewPubDataMembersIter: avoid using deprecated std::iterator#10457

Merged
jalopezg-git merged 1 commit intoroot-project:masterfrom
jalopezg-git:fix-10351
Apr 27, 2022
Merged

[core] TViewPubDataMembersIter: avoid using deprecated std::iterator#10457
jalopezg-git merged 1 commit intoroot-project:masterfrom
jalopezg-git:fix-10351

Conversation

@jalopezg-git
Copy link
Copy Markdown
Contributor

@jalopezg-git jalopezg-git commented Apr 26, 2022

std::iterator<...> was deprecated in C++17; manually declare the expected member types instead.

Checklist:

  • tested changes locally

This PR fixes #10351.

@jalopezg-git
[core] TViewPubDataMembersIter: avoid using deprecated std::iterator
e6121fd 
`std::iterator` was deprecated in C++17; manually declare the member types.

Fixes root-project#10351.
@jalopezg-git jalopezg-git self-assigned this Apr 26, 2022
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 26, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 26, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

And 4 more

pcanal
pcanal approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 27, 2022

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@jalopezg-git jalopezg-git mentioned this pull request Apr 27, 2022
Merged
1 task
@jalopezg-git
Copy link
Copy Markdown
Contributor Author

jalopezg-git commented Apr 27, 2022

Failing tests:

* [projectroot.roottest.cling.dict.ROOT-7879.roottest_cling_dict_ROOT_7879_skipLinkDefDict](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.cling.dict/ROOT-7879/roottest_cling_dict_ROOT_7879_skipLinkDefDict/)

* [projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stltest](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.meta/MakeProject/roottest_root_meta_MakeProject_stltest/)

* [projectroot.roottest.root.aclic.misc.roottest_root_aclic_misc_assertROOT7027](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.aclic/misc/roottest_root_aclic_misc_assertROOT7027/)

* [projectroot.roottest.root.aclic.load.roottest_root_aclic_load_reload](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.aclic/load/roottest_root_aclic_load_reload/)

* [projectroot.roottest.root.io.uniquePointer.roottest_root_io_uniquePointer_customDeleteError](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.io/uniquePointer/roottest_root_io_uniquePointer_customDeleteError/)

* [projectroot.roottest.root.io.stdarray.roottest_root_io_stdarray_modelReadDict2TFile](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.io/stdarray/roottest_root_io_stdarray_modelReadDict2TFile/)

* [projectroot.roottest.root.meta.genreflex.roottest_root_meta_genreflex_ioreadrulesfailonwarning](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.meta/genreflex/roottest_root_meta_genreflex_ioreadrulesfailonwarning/)

* [projectroot.roottest.root.meta.genreflex.roottest_root_meta_genreflex_vectorOfTStar](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.meta/genreflex/roottest_root_meta_genreflex_vectorOfTStar/)

* [projectroot.roottest.root.meta.genreflex.roottest_root_meta_genreflex_twoTypedefsOneClass](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.meta/genreflex/roottest_root_meta_genreflex_twoTypedefsOneClass/)

* [projectroot.roottest.root.meta.genreflex.roottest_root_meta_genreflex_privateClassXMLSelection](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/143298/testReport/projectroot.roottest.root.meta/genreflex/roottest_root_meta_genreflex_privateClassXMLSelection/)

These failures are totally unrelated.

@jalopezg-git jalopezg-git merged commit 98cd766 into root-project:master Apr 27, 2022
@jalopezg-git jalopezg-git deleted the fix-10351 branch April 27, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@jalopezg-git jalopezg-git

Labels

affects:master in:Core Libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macOS 12: TViewPubDataMembers uses deprecated std::iterator

3 participants

@jalopezg-git @phsft-bot @pcanal