[Math] Fix memory leak when using GSLMultiFit and improve Fitter class#10439
Merged
lmoneta merged 3 commits intoroot-project:masterfrom Apr 28, 2022
Merged
[Math] Fix memory leak when using GSLMultiFit and improve Fitter class#10439lmoneta merged 3 commits intoroot-project:masterfrom
lmoneta merged 3 commits intoroot-project:masterfrom
Conversation
…n functiona in the BasicMinimizer and their derived classes. Thia fixes the memory leak observed in the ROOT Forum. (See https://root-forum.cern.ch/t/gslmultifit-memory-leak-with-root-fitter/49566 )
Refactor some of the fitting code avoiding a Clone of the chi2 or likelihood function. Make better used of the shared pointer to the objective function
|
Starting build on |
guitargeek
reviewed
Apr 27, 2022
| FitTransformFunction(const FitMethodFunction & f, MinimTransformFunction *transFunc ) : | ||
| FitMethodFunction( f.NDim(), f.NPoints() ), | ||
| fOwnTransformation(false), | ||
| fOwnTransformation(true), |
Contributor
There was a problem hiding this comment.
PR look good to me, thanks for the improvements in the ownership model!
Now that you use smart pointers, can this fOwnTransformation member be removed?
Member
Author
There was a problem hiding this comment.
Thank you for the comment. I have now improved also that internal class and the data member is removed!
guitargeek
requested changes
Apr 27, 2022
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks for the PR, I only have one request about the fOwnTransformation member.
Include comment of Jonas, and use now unique_ptr for managing the TransformFunction pointer. Remove also a constructor which was not used and was actually leaking memory.
|
Starting build on |
guitargeek
approved these changes
Apr 28, 2022
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you for the update, looks very good now!
|
Build failed on mac1015/python3. Errors:
|
lmoneta
added a commit
to lmoneta/root
that referenced
this pull request
Jan 26, 2024
A bug was introduced in root-project#10439 affecting the weighted likelihood fits
lmoneta
added a commit
to lmoneta/root
that referenced
this pull request
Jan 26, 2024
A bug was introduced in root-project#10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
lmoneta
added a commit
that referenced
this pull request
Jan 30, 2024
A bug was introduced in #10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
lmoneta
added a commit
to lmoneta/root
that referenced
this pull request
Jan 30, 2024
A bug was introduced in root-project#10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
lmoneta
added a commit
to lmoneta/root
that referenced
this pull request
Jan 30, 2024
A bug was introduced in root-project#10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
lmoneta
added a commit
that referenced
this pull request
Feb 1, 2024
A bug was introduced in #10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
lmoneta
added a commit
that referenced
this pull request
Feb 1, 2024
A bug was introduced in #10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
ferdymercury
pushed a commit
to ferdymercury/root
that referenced
this pull request
Apr 10, 2025
A bug was introduced in root-project#10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request fixes a memory leak reported in https://root-forum.cern.ch/t/gslmultifit-memory-leak-with-root-fitter/49566 when using GSLMultiFit.
In addition for fixing for the leak the handling of the internal transformation function is improved and an extra un-needed clone of the objective function in the Fitter class is avoided.