Skip to content

[I/O] Use thread-local collection proxy in TClass::Destructor#10361

Merged
eguiraud merged 1 commit intoroot-project:masterfrom
eguiraud:fix-io-race
Apr 10, 2022
Merged

[I/O] Use thread-local collection proxy in TClass::Destructor#10361
eguiraud merged 1 commit intoroot-project:masterfrom
eguiraud:fix-io-race

Conversation

@eguiraud
Copy link
Copy Markdown
Contributor

@eguiraud eguiraud commented Apr 8, 2022 •
edited
Loading

This fixes #10357 (a race condition when reading vectors with custom
allocators with TTreeProcessorMT that also affected RDataFrame).

Co-authored-by: Philippe Canal [email protected]

EDIT: regression test at root-project/roottest#866

@eguiraud @pcanal
[I/O] Use thread-local collection proxy in TClass::Destructor
ec8da9d 
This fixes root-project#10357 (a race condition when reading vectors with custom
allocators with TTreeProcessorMT that also affected RDataFrame).

Co-authored-by: Philippe Canal <[email protected]>
@eguiraud eguiraud requested review from Axel-Naumann and pcanal April 8, 2022 13:26
@eguiraud eguiraud self-assigned this Apr 8, 2022
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 8, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 8, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2022-04-08T14:09:29.686Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Serialization\obj.clangSerialization.vcxproj]
  • [2022-04-08T14:09:29.686Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Basic\obj.clangBasic.vcxproj]
  • [2022-04-08T14:09:29.686Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/Support/CommandLine.h(50,14): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Scalar\LoopStrengthReduce.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Scalar\LLVMScalarOpts.vcxproj]
  • [2022-04-08T14:09:29.686Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Basic\obj.clangBasic.vcxproj]
  • [2022-04-08T14:09:29.686Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\algorithm(6640,66): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Driver\ToolChains\DragonFly.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Driver\obj.clangDriver.vcxproj]
  • [2022-04-08T14:09:29.686Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\list(880,63): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Analysis\CloneDetection.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Analysis\obj.clangAnalysis.vcxproj]
  • [2022-04-08T14:09:29.686Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\functional(578,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Lex\PreprocessingRecord.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Lex\obj.clangLex.vcxproj]
  • [2022-04-08T14:09:29.686Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Basic\obj.clangBasic.vcxproj]
  • [2022-04-08T14:09:29.686Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Serialization\obj.clangSerialization.vcxproj]
  • [2022-04-08T14:10:58.729Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\tuple(713,52): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Scalar\LowerWidenableCondition.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Scalar\LLVMScalarOpts.vcxproj]

And 44 more

@eguiraud
Copy link
Copy Markdown
Contributor Author

eguiraud commented Apr 10, 2022

@phsft-bot build

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 10, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@eguiraud eguiraud merged commit 5a125ab into root-project:master Apr 10, 2022
@eguiraud eguiraud deleted the fix-io-race branch April 10, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@eguiraud eguiraud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[I/O] Race condition when reading vectors with custom allocators with TTreeProcessorMT

3 participants

@eguiraud @phsft-bot @pcanal