Auto-select firmware when only one option is available#3150
Merged
Conversation
Copilot
AI
changed the title
[WIP] Auto select firmware if only one file is available
Auto-select firmware when only one option is available
Mar 21, 2026
gantoine
approved these changes
Mar 21, 2026
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EmulatorJS Player view to automatically select a firmware file when the current platform has exactly one available option, reducing unnecessary manual selection in the UI.
Changes:
- Add a
biosFromSingleOptionfallback to firmware resolution on mount. - Update firmware selection priority to: localStorage → config.yml
bios_file→ single available option →null.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a platform has exactly one firmware file, the EmulatorJS player required manual selection from a single-item dropdown. It now auto-selects that file on mount.
Changes
frontend/src/views/Player/EmulatorJS/Base.vue— addedbiosFromSingleOptionas the last fallback in the firmware resolution chain:Resolution priority (highest → lowest):
biosFromStorage— user's last localStorage selectionbiosFromConfig—bios_fileset inconfig.ymlbiosFromSingleOption(new) — auto-select when exactly one firmware existsnullOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.