feat: update RAHasher to version 1.8.3 and add Wii platform support#3145
feat: update RAHasher to version 1.8.3 and add Wii platform support#3145
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Test Results (postgresql)998 tests 997 ✅ 2m 34s ⏱️ Results for commit a18fd9c. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
Updates the bundled RetroAchievements hashing tool (RAHasher) to the latest upstream release and wires up Wii as a supported RetroAchievements platform ID so Wii ROMs can have RA hashes calculated.
Changes:
- Bump RALibretro/RAHasher build from 1.8.1 → 1.8.3 (and remove now-unneeded source patching steps).
- Add Wii (RA platform ID
19) to the RetroAchievements platform mapping(s). - Update RAHasher subprocess success exit-code handling to treat
0as success.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Dockerfile |
Builds RAHasher from RALibretro tag 1.8.3 and removes build-time patching. |
DEVELOPER_SETUP.md |
Updates manual setup instructions to checkout/build RAHasher 1.8.3 and removes the previous header patch step. |
backend/handler/metadata/ra_handler.py |
Adds Wii to the RetroAchievements platform list (slug → RA system ID). |
backend/adapters/services/rahasher.py |
Adds Wii to the RAHasher platform mapping and updates success exit-code expectation to 0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results (mariadb)998 tests 997 ✅ 2m 33s ⏱️ Results for commit a18fd9c. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Description
Explain the changes or enhancements you are proposing with this pull request.
RAHaser added wii support with 1.8.3 release
Also, 1.8.2 release fixed RAHaser exit codes and missing includes in some source files
Checklist
Please check all that apply.
Screenshots (if applicable)