fix: add missing platforms to playable game filter#3121
fix: add missing platforms to playable game filter#3121zurdi15 merged 4 commits intorommapp:masterfrom
Conversation
Greptile SummaryThis PR fixes the "playable" smart collection filter by adding three missing EJS-supported platforms (
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[_filter_by_playable called] --> B{value == True?}
B -- Yes --> C["predicate = or(\n slug IN EJS_SUPPORTED_PLATFORMS,\n slug IN OTHER_SUPPORTED_PLATFORMS\n)"]
B -- No --> D["predicate = not_(or(\n slug IN EJS_SUPPORTED_PLATFORMS,\n slug IN OTHER_SUPPORTED_PLATFORMS\n))"]
C --> E[query.join Platform .filter predicate]
D --> E
subgraph EJS_SUPPORTED_PLATFORMS
F["3DO, AMIGA, ARCADE, ATARI*, C64, DOS ✨\nGBC ✨, SEGA32 ✨, GBA, NES, N64\nNDS, PSX, PSP, GENESIS, SNES, ..."]
end
subgraph OTHER_SUPPORTED_PLATFORMS
G["BROWSER ✨ (Ruffle)"]
end
C --> EJS_SUPPORTED_PLATFORMS
C --> OTHER_SUPPORTED_PLATFORMS
|
There was a problem hiding this comment.
what is UPS.BROWSER? if its the flash games/browser games platform, add it to the list, don't make an or in the predicate
Edit: UPS.BROWSER already exists in the UPS object, so add it to the EJS_SUPPORTED_PLATFORMS list or create a new list OTHER_SUPPORTED_PLATFORMS and add it there so if in the future we add a new playable platform from outside of emujs we will add it there
|
Okay, I created a |
Description
Noticed some games not showing up in my "playable" smart collection, turns out a couple supported platforms weren't included in the _filter_by_playable function.
Checklist