Greptile Summary

This PR fixes a bug in the LaunchBox metadata handler where the dash-to-colon substitution (converting " - "/"- " → ": ") was only applied when keep_tags=False, meaning searches triggered via get_matched_roms_by_name (which passes keep_tags=True) would fail to match LaunchBox entries that use colons in their titles. The fix moves the re.sub call outside the if/else block so it applies unconditionally before the remote lookup.

• Bug fix (core): re.sub(DASH_COLON_REGEX, ": ", search_term).lower() is now applied to search_term regardless of the keep_tags value, ensuring consistent title normalization for both scan-time and manual-search paths.
• Cleanup: get_matched_roms_by_name now passes keep_tags=True as a keyword argument instead of a positional boolean for readability.
• Cleanup: get_matched_rom_by_id removes the redundant explicit remote_enabled=True since it matches the default value of the parameter.

Confidence Score: 5/5

• This PR is safe to merge — it applies a straightforward one-line reordering to fix a clear bug, with no side effects.
• The change is minimal and surgical: the substitution was already correct in the keep_tags=False path, and moving it outside the conditional simply extends the same behavior to the keep_tags=True path without altering any other logic. The two cleanup changes (keyword arg and removing an explicit default) are functionally identical to what was there before.
• No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["get_rom(fs_name, platform_slug, keep_tags)"] --> B{Local match found?}
    B -- Yes --> C[Return local + remote merged ROM]
    B -- No --> D{LaunchBox ID tag in filename?}
    D -- Yes --> E[get_rom_by_id]
    E --> F{ID found?}
    F -- Yes --> G[Return ROM by ID]
    F -- No --> H{remote_available?}
    D -- No --> H
    H -- No --> I[Return fallback_rom]
    H -- Yes --> J{keep_tags?}
    J -- "False" --> K["search_term = get_file_name_with_no_tags(fs_name)"]
    J -- "True" --> L["search_term = fs_name"]
    K --> M["re.sub(DASH_COLON_REGEX, ': ', search_term).lower()  ← applied in BOTH branches now"]
    L --> M
    M --> N{platform_slug == SCUMMVM?}
    N -- Yes --> O["_scummvm_format(search_term)"]
    N -- No --> P["_remote.get_rom(search_term, ...)"]
    O --> P
    P --> Q{index_entry found?}
    Q -- No --> R[Return fallback_rom]
    Q -- Yes --> S[Return remote ROM]

_{Last reviewed commit: 207f8a3}

Test Results (postgresql)

942 tests  ±0   941 ✅ ±0   2m 15s ⏱️ -1s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 207f8a3. ± Comparison against base commit 9dd155a.

Test Results (mariadb)

942 tests  ±0   941 ✅ ±0   2m 15s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 207f8a3. ± Comparison against base commit 9dd155a.

☂️ Python Coverage

current status: ✅

Overall Coverage

New Files

No new covered files...

Modified Files

updated for commit: 207f8a3 by action🐍