Add video_normalized media type option for ScreenScraper scans#3088
Merged
Add video_normalized media type option for ScreenScraper scans#3088
video_normalized media type option for ScreenScraper scans#3088Conversation
Co-authored-by: gantoine <[email protected]>
Copilot
AI
changed the title
[WIP] Add video-normalized to config.yml for scan.media
Add Mar 8, 2026
video_normalized media type option for ScreenScraper scans
gantoine
approved these changes
Mar 8, 2026
Contributor
Contributor
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Greptile SummaryThis PR adds
Confidence Score: 5/5
Last reviewed commit: 7f88923 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScreenScraper exposes both
videoandvideo-normalizedfor each game. Onlyvideowas supported, with no way to opt into the normalized variant (~57% smaller in practice).Changes
MetadataMediaTypeenum — addsVIDEO_NORMALIZED = "video_normalized", making it a validscan.mediaconfig value that passes existing validationSSMetadataMediaTypedDict — addsvideo_normalized_pathfield; extraction logic now sets it (and triggers download) whenvideo_normalizedis in preferred media types, storing toroms/{platform_id}/{rom_id}/video_normalized/video-normalized.mp4RomSSMetadataTS type — addsvideo_normalized_pathto the generated modelMediaCarousel.vueanduseGameAnimation.tsfall back tovideo_normalized_pathwhenvideo_pathis absentconfig.example.yml— documents the new optionUsage
The existing generic download loop in
scan.py({media_type.value}_url/{media_type.value}_path) picks up the new type with no changes required there.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.