Skip to content

Ugprade some docker base images#3032

Merged
gantoine merged 4 commits intomasterfrom
docker-base-image-upgrades
Feb 17, 2026
Merged

Ugprade some docker base images#3032
gantoine merged 4 commits intomasterfrom
docker-base-image-upgrades

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Feb 17, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

  • Node 18 -> 24
  • Alpine 3.22 -> 3.23

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 17, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's core dependencies by upgrading the Node.js runtime and the Alpine Linux base image within the Docker environment. These updates aim to leverage the latest features, security patches, and performance improvements offered by the newer versions of these critical components, ensuring the application remains robust and maintainable.

Highlights

  • Node.js Upgrade: The Node.js version used in the Docker build process and frontend project has been upgraded from Node 18 (or 20 in some cases) to Node 24.13.1.
  • Alpine Linux Upgrade: The base Alpine Linux version for the Docker images has been updated from 3.22 to 3.23.
  • Nginx Version Update: The Nginx version specified in the Docker build arguments has been updated from 1.29.2 to 1.29.
Changelog
  • Dockerfile
    • Updated the Node.js version installed via NVM from 18.20.8 to 24.13.1.
    • Adjusted the NVM use and alias default commands to reflect the new Node.js version.
    • Updated the PATH environment variable to point to the new Node.js 24.13.1 binary.
    • Updated the ALPINE_VERSION argument from 3.22 to 3.23.
    • Updated the ALPINE_SHA256 checksum for the new Alpine version.
    • Updated the PYTHON_ALPINE_SHA256 checksum.
    • Updated the NODE_VERSION argument from 20.19 to 24.13.
    • Updated the NODE_ALPINE_SHA256 checksum for the new Node version.
    • Updated the NGINX_VERSION argument from 1.29.2 to 1.29.
    • Updated the NGINX_SHA256 checksum for the new Nginx version.
  • docker/Dockerfile
    • Updated the ALPINE_VERSION argument from 3.22 to 3.23.
    • Updated the ALPINE_SHA256 checksum for the new Alpine version.
    • Updated the PYTHON_ALPINE_SHA256 checksum.
    • Updated the NODE_VERSION argument from 20.19 to 24.13.
    • Updated the NODE_ALPINE_SHA256 checksum for the new Node version.
    • Updated the NGINX_VERSION argument from 1.29.2 to 1.29.
    • Updated the NGINX_SHA256 checksum for the new Nginx version.
  • frontend/.nvmrc
    • Changed the specified Node.js version from 20 to 24.
  • frontend/package-lock.json
    • Modified the engines.node requirement from >18 to 24.
  • frontend/package.json
    • Modified the engines.node requirement from >18 to 24.
Activity
  • The author has tested the changes locally.
  • The author has updated relevant comments within the code.
  • The author has assigned reviewers for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades Node.js from versions 18 and 20 to 24, and Alpine from 3.22 to 3.23 across several Dockerfiles and configuration files. The changes are mostly consistent, but I've found a critical issue with the NGINX version that will likely break the build. I've also added a recommendation regarding the Node.js version for production stability.

@gantoine gantoine merged commit 91150c5 into master Feb 17, 2026
7 checks passed
@gantoine gantoine deleted the docker-base-image-upgrades branch February 17, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gantoine