Skip to content

[ROMM-2943] Match scanned platform based on fs_slug#3008

Merged
gantoine merged 1 commit intomasterfrom
romm-2943
Feb 9, 2026
Merged

[ROMM-2943] Match scanned platform based on fs_slug#3008
gantoine merged 1 commit intomasterfrom
romm-2943

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Feb 9, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2943

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where scanned platforms were not being correctly associated with ROMs due to an incorrect property being used in the matching logic. By switching to fs_slug for platform identification, the system now accurately links scanned items to their respective platforms, improving the reliability of the scanning process.

Highlights

  • Platform Matching Logic Update: The logic for matching scanned platforms has been updated to use the fs_slug property instead of the slug property. This ensures that platforms are correctly identified based on their file system slug, addressing the issue described in ROMM-2943.
Changelog
  • frontend/src/components/common/Navigation/ScanBtn.vue
    • Modified the platform lookup within the processRomUpdates function to compare p.fs_slug with rom.platform_fs_slug instead of p.slug with rom.platform_slug.
Activity
  • The author has tested the changes locally.
  • Reviewers have been assigned for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in matching scanned platforms during a ROM scan process. The change updates the logic to use fs_slug and platform_fs_slug for comparison, instead of slug and platform_slug. This is the correct approach, as fs_slug is the identifier used on the backend for platforms based on the filesystem, ensuring a reliable match. The change is well-targeted and effectively resolves the issue.

@gantoine gantoine merged commit 6ea4ae3 into master Feb 9, 2026
7 checks passed
@gantoine gantoine deleted the romm-2943 branch February 9, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Scan results show all found roms in the first library of given type

1 participant

@gantoine