Skip to content

[ROMM-2965] Check file count for file select menu emulatorjs#3005

Merged
gantoine merged 1 commit intomasterfrom
romm-2965
Feb 9, 2026
Merged

[ROMM-2965] Check file count for file select menu emulatorjs#3005
gantoine merged 1 commit intomasterfrom
romm-2965

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Feb 9, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2965

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the conditional rendering logic within the EmulatorJS player component. It replaces a boolean flag with a direct check of the number of associated ROM files to determine the visibility of the disc selection menu and a configuration divider. This change ensures that these UI elements are displayed accurately based on whether a ROM has multiple files, addressing a potential display inconsistency.

Highlights

  • Conditional Rendering Logic Update: The logic for conditionally displaying the disc selector in the EmulatorJS player has been updated to directly check the length of the rom.files array instead of relying on the rom.has_multiple_files boolean property.
  • Divider Visibility Condition Refinement: The condition for rendering a visual divider within the EmulatorJS configuration section has also been updated to use rom.files.length > 1, aligning with the disc selector's new logic.
Changelog
  • frontend/src/views/Player/EmulatorJS/Base.vue
    • Updated the v-if condition for the disc selector (v-select) from rom.has_multiple_files to rom.files.length > 1.
    • Modified the v-if condition for a v-divider component from rom.has_multiple_files to rom.files.length > 1.
Activity
  • The author has tested the changes locally.
  • Reviewers have been assigned for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the logic for showing the file/disc selection UI in the EmulatorJS player. The change replaces the use of the rom.has_multiple_files property with a direct check of rom.files.length > 1. This is a positive change that improves code clarity and robustness by relying directly on the files array, which is the source of truth, rather than a pre-calculated boolean flag. The implementation is correct and enhances maintainability.

@gantoine gantoine merged commit e611b0e into master Feb 9, 2026
0 of 5 checks passed
@gantoine gantoine deleted the romm-2965 branch February 9, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Multi-file games with subfolders (patches/translations) fail to launch in EJS

1 participant

@gantoine