Skip to content

[ROMM-2972] Fix /props returning stale data#3003

Merged
gantoine merged 2 commits intomasterfrom
romm-2972
Feb 9, 2026
Merged

[ROMM-2972] Fix /props returning stale data#3003
gantoine merged 2 commits intomasterfrom
romm-2972

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Feb 9, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2972

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the /props endpoint was serving stale data by updating the roms_handler to ensure database objects are always current. Additionally, it enhances the HLTB metadata handler by adding a new initialization URL.

Highlights

  • Fix for Stale Data in RomUser Updates: The update_rom_user function in roms_handler.py has been refactored to ensure that the RomUser object is always fetched directly from the current database session. This change prevents the return of stale data by guaranteeing that operations are performed on the most up-to-date record, addressing the issue of /props returning outdated information.
  • HLTB Search Initialization URL: A new search_init_url attribute has been introduced in hltb_handler.py. This URL is dynamically constructed by appending /init to the base search_url after it is retrieved, likely to provide a dedicated endpoint for initializing HLTB search operations.
Changelog
  • backend/handler/database/roms_handler.py
    • Replaced the call to self.get_rom_user_by_id(id) with a direct session.query(RomUser).filter_by(id=id).one() to fetch the RomUser object, ensuring it is always retrieved fresh from the current session.
    • Removed the explicit if not rom_user: return None check, as the .one() method will raise an exception if no matching record is found, simplifying error handling.
    • Modified the function's return statement to reuse the rom_user object that was already fetched and updated, eliminating an unnecessary subsequent database query.
  • backend/handler/metadata/hltb_handler.py
    • Added a new instance attribute self.search_init_url which is derived by concatenating /init to the self.search_url after the latter has been successfully fetched from GitHub.
Activity
  • The author, gantoine, has marked that the changes have been tested locally.
  • The author, gantoine, has marked that relevant comments have been updated.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where stale data was being returned for ROM properties. The changes in backend/handler/database/roms_handler.py correctly modify the update_rom_user function to use the existing database session, preventing stale reads from a separate transaction. The PR also includes an optimization to avoid a redundant database query. Additionally, a fix in backend/handler/metadata/hltb_handler.py ensures the HowLongToBeat API initialization URL is correctly updated along with the dynamic search URL. The identified comment regarding the use of .one_or_none() is valid and addresses a potential regression in error handling, which could lead to unhandled exceptions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

Test Results

801 tests  ±0   800 ✅ ±0   2m 5s ⏱️ +3s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 66ee724. ± Comparison against base commit c5cb2a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12857 8472 66% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/database/roms_handler.py 54% 🟢
backend/handler/metadata/hltb_handler.py 48% 🟢
TOTAL 51% 🟢

updated for commit: 66ee724 by action🐍

@gantoine gantoine merged commit 450e3ca into master Feb 9, 2026
8 checks passed
@gantoine gantoine deleted the romm-2972 branch February 9, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] /rom/{id}/props returns stale data

1 participant