Skip to content

[ROMM-2983] Fix negative filter by verified#3000

Merged
gantoine merged 1 commit intomasterfrom
romm-2983
Feb 7, 2026
Merged

[ROMM-2983] Fix negative filter by verified#3000
gantoine merged 1 commit intomasterfrom
romm-2983

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Feb 7, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2983

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 7, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the 'filter by verified' functionality in the ROM management system did not properly handle negative filtering. The changes introduce a boolean parameter to the verification filter method, enabling it to construct appropriate database queries for both verified and unverified states, thus ensuring accurate data retrieval based on verification status.

Highlights

  • Enhanced Filtering Logic: The _filter_by_verified method now correctly supports filtering for both verified and unverified ROMs by accepting a boolean value parameter.
  • Dynamic Predicate Construction: The internal logic within _filter_by_verified has been updated to dynamically apply a NOT condition to the generated SQL predicate or SQLAlchemy not_ operator when filtering for unverified ROMs.
  • Removed TODO Comment: A TODO comment in the filter_roms method regarding correct support for true/false values in verification filtering has been removed, as the functionality is now implemented.
Changelog
  • backend/handler/database/roms_handler.py
    • Modified the _filter_by_verified method signature to include a value: bool parameter.
    • Updated the implementation of _filter_by_verified to apply a NOT condition to the generated SQL or SQLAlchemy predicate when value is False.
    • Adjusted the call to _filter_by_verified within filter_roms to pass the verified boolean value, replacing a previous TODO comment.
Activity
  • The author, gantoine, has opened this pull request to address issue ROMM-2983.
  • Local testing of the changes has been completed by the author.
  • Relevant comments within the codebase have been updated.
  • Reviewers have not yet been assigned for this pull request.
  • Unit tests covering the new changes have not yet been added.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements negative filtering for the 'verified' status, which was a missing feature. The changes to _filter_by_verified and its call site in filter_roms are logical and address the issue. I've included one suggestion to refactor the _filter_by_verified method to reduce code duplication and improve maintainability by using a more consistent approach for predicate negation across different database drivers.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 7, 2026

Test Results

801 tests  ±0   800 ✅ ±0   2m 0s ⏱️ -2s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4733a86. ± Comparison against base commit a902950.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 7, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12860 8479 66% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/database/roms_handler.py 54% 🟢
TOTAL 54% 🟢

updated for commit: 4733a86 by action🐍

@gantoine gantoine merged commit 8b359a9 into master Feb 7, 2026
8 checks passed
@gantoine gantoine deleted the romm-2983 branch February 7, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Show Verified filter is not working

1 participant

@gantoine