Conversation
Summary of ChangesHello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with how search terms are handled when querying the HowLongToBeat (HLTB) API. The primary modification involves adjusting the search payload to send individual words from a search query, rather than the entire phrase as a single term, which is expected to yield more precise search results. Additionally, a minor internal refactoring was performed to standardize the construction of a search initialization URL. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix how search terms are fetched for HowLongToBeat. The changes correctly update the search_init_url to be relative to the dynamic search_url, which is a good improvement for maintainability. The PR also modifies how search terms are prepared for the API request. I've provided one suggestion to make the splitting of search terms more robust against different whitespace patterns, which will improve the reliability of the search functionality.
| payload = { | ||
| "searchType": "games", | ||
| "searchTerms": [search_term], | ||
| "searchTerms": search_term.split(" "), |
There was a problem hiding this comment.
Using search_term.split(" ") can produce empty strings in the searchTerms list if the input search_term contains multiple spaces between words (e.g., "Game Name".split(" ") results in ['Game', '', 'Name']). This might cause unexpected behavior from the HLTB API.
To make this more robust, I recommend using search_term.split() without arguments. It handles any amount of whitespace and correctly discards empty strings.
| "searchTerms": search_term.split(" "), | |
| "searchTerms": search_term.split(), |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
1 participant
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2997
Checklist
Please check all that apply.