Skip to content

[ROMM-2991] Allow set completion to 0#2995

Merged
gantoine merged 1 commit intomasterfrom
romm-2991
Feb 6, 2026
Merged

[ROMM-2991] Allow set completion to 0#2995
gantoine merged 1 commit intomasterfrom
romm-2991

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Feb 6, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2991

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 6, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the user interface prevented setting a completion value of zero. By adjusting the minimum allowed value for the completion input field, it now correctly supports a zero completion status, aligning the frontend behavior with the intended functionality.

Highlights

  • Frontend UI Update: The minimum value for the completion input field in the Personal.vue component has been changed from 1 to 0, allowing users to set their completion status to zero.
Changelog
  • frontend/src/components/Details/Personal.vue
    • Updated the min attribute of the v-model="romUser.completion" input field from 1 to 0.
Activity
  • The author has indicated that the changes have been tested locally.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a small but necessary fix to allow the completion percentage of a ROM to be set to 0. By changing the min attribute of the v-slider from 1 to 0, it now correctly reflects that 0% is a valid state for completion. The change is well-contained and I couldn't find any negative side-effects in the provided code. Good job.

@gantoine gantoine merged commit 656e5b0 into master Feb 6, 2026
7 checks passed
@gantoine gantoine deleted the romm-2991 branch February 6, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Unable to set "Completion %" to 0

1 participant

@gantoine