Skip to content

filter keys now plural#2982

Merged
gantoine merged 3 commits intorommapp:masterfrom
camhorn:plural-filter-keys
Feb 3, 2026
Merged

filter keys now plural#2982
gantoine merged 3 commits intorommapp:masterfrom
camhorn:plural-filter-keys

Conversation

@camhorn
Copy link
Copy Markdown
Contributor

@camhorn camhorn commented Feb 3, 2026

Description
What with the filter refactoring, these keys need to be their plural forms for the searches to work.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots (if applicable)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 3, 2026

Summary of Changes

Hello @camhorn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the filter keys within the GameInfo.vue component to their plural forms. This change is a direct consequence of a recent filter refactoring and is necessary to ensure that the application's search functionality operates as expected.

Highlights

  • Filter Key Pluralization: Updated filter keys in GameInfo.vue from singular to plural forms (e.g., "region" to "regions", "language" to "languages") to ensure compatibility with recent filter refactoring.
  • Search Functionality Alignment: This modification is crucial for the search operations to function correctly, aligning the keys with the updated search logic.
Changelog
  • frontend/src/components/Details/Info/GameInfo.vue
    • Modified the filters array by changing the key property of several filter objects from singular to plural. This includes keys such as "region", "language", "genre", "franchise", "collection", "company", and "playerCount".
Activity
  • No human activity has been recorded on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 3, 2026

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@gantoine
Copy link
Copy Markdown
Member

gantoine commented Feb 3, 2026

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates filter keys to their plural forms across GameInfo.vue and galleryFilter.ts to align with a recent filter refactoring. The changes are consistent and correctly applied. I've added a couple of suggestions to improve code maintainability by sorting the filter definitions alphabetically.

@gantoine gantoine merged commit 8e551a6 into rommapp:master Feb 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gantoine gantoine gantoine approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camhorn @gantoine