Skip to content

Use vite copy plugin to load rom-patcher#2964

Merged
gantoine merged 2 commits intomasterfrom
romm-2946
Jan 30, 2026
Merged

Use vite copy plugin to load rom-patcher#2964
gantoine merged 2 commits intomasterfrom
romm-2946

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 30, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2946

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue related to loading rom-patcher modules in the frontend by implementing a static asset copying mechanism. By utilizing the vite-plugin-static-copy, the necessary rom-patcher files are now correctly placed and referenced in the build, ensuring their availability and proper functioning at runtime.

Highlights

  • New Vite Plugin Integration: The vite-plugin-static-copy has been introduced to the frontend build process to manage static asset copying.
  • Rom-Patcher Asset Handling: The rom-patcher JavaScript files are now explicitly copied from node_modules to a dedicated /rom-patcher directory in the build output, ensuring proper accessibility.
  • Worker Script Path Update: The patcher.worker.js script has been updated to reference the rom-patcher modules from their new, copied location (/rom-patcher/) instead of the node_modules path.
  • Dependency Metadata Standardization: Numerous devOptional: true entries in package-lock.json have been corrected to dev: true, standardizing the declaration of development dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors how the rom-patcher library is handled in the build process. By using vite-plugin-static-copy, the necessary scripts are now explicitly copied to the build output directory, which is a more robust solution than relying on files being served from node_modules. The changes in vite.config.js and the worker script are consistent and well-implemented. I have one suggestion to make the file glob pattern in the Vite configuration more specific to improve future-proofing and build optimization.

@gantoine gantoine merged commit 983da2c into master Jan 30, 2026
7 checks passed
@gantoine gantoine deleted the romm-2946 branch January 30, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Patcher doesn't work

1 participant

@gantoine