Skip to content

[ROMM-2956] Fix refresh on card edit#2962

Merged
gantoine merged 1 commit intomasterfrom
romm-2956
Jan 29, 2026
Merged

[ROMM-2956] Fix refresh on card edit#2962
gantoine merged 1 commit intomasterfrom
romm-2956

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 29, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fix #2956

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a refresh issue (ROMM-2956) related to card editing by refining how collection card routes are handled. The changes ensure that the v-card component correctly manages its navigation link, preventing potential errors when a card is not meant to be clickable or when its route is not yet determined. This improves the robustness and reliability of card interactions within the application.

Highlights

  • Conditional Routing Logic: The collectionRoute computed property now explicitly returns null instead of an empty object {} when a card should not have an associated link (i.e., when withLink is false or collection is undefined).
  • Dynamic v-card Link Binding: The v-card component's to prop is now conditionally bound. It will only apply the to prop if collectionRoute has a valid value, preventing the binding of to: null which could lead to unexpected behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where editing a card could cause a page refresh. The fix correctly changes the collectionRoute computed property to return null for non-linkable cards, preventing the v-card from being rendered as a link with an invalid destination. I've suggested a small simplification in the template to make the code more concise and readable by binding directly to the :to prop.

@gantoine gantoine merged commit e1118a0 into master Jan 29, 2026
7 checks passed
@gantoine gantoine deleted the romm-2956 branch January 29, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Selecting to upload Collection art immediately refreshes page

1 participant

@gantoine