Skip to content

[HOTFIX] Fix all roms displayed in all platforms#2948

Merged
gantoine merged 1 commit intomasterfrom
all-roms-in-all-platforms
Jan 28, 2026
Merged

[HOTFIX] Fix all roms displayed in all platforms#2948
gantoine merged 1 commit intomasterfrom
all-roms-in-all-platforms

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 28, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Some users are seeing all roms in each platform view, and this PR attempts to fix that without a) being able to duplicate it or b) affecting working installs.

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots (if applicable)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 28, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a hotfix to resolve an issue where users were incorrectly seeing all ROMs across all platforms, even when a specific platform was selected. The core change involves reordering the precedence for identifying the active platform(s) when fetching ROMs, ensuring that the currently viewed single platform takes priority. This adjustment aims to correct the display behavior without impacting existing functional installations.

Highlights

  • Platform ID Determination Logic: The logic within the _buildRequestParams method in frontend/src/stores/roms.ts has been refactored to correctly determine which platform IDs to use when fetching ROMs.
  • Prioritization of currentPlatform: The updated logic now prioritizes this.currentPlatform (which indicates a single platform view) over multi-selection filters from galleryFilter.selectedPlatforms, ensuring the correct ROMs are displayed for the selected platform.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where users might see roms from all platforms instead of the selected one. The change refactors the logic for determining platform filters by prioritizing the currentPlatform context over other filter settings. This makes the filtering more robust, especially when navigating between different views. The new logic is clearer and should prevent unexpected behavior caused by stale filter states. The change looks good and correctly addresses the likely cause of the issue.

@gantoine gantoine merged commit 875dc56 into master Jan 28, 2026
7 checks passed
@gantoine gantoine deleted the all-roms-in-all-platforms branch January 28, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gantoine