Add workflow to run migrations on PR#2941
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves a docstring and removes a hardcoded secret key from the test configuration, which is a good security improvement. However, the PR title and description are misleading as they refer to adding a new workflow for running migrations, which isn't part of these changes. Please update the title and description to match the content.
On a related note, I observed that the modified migration file has an empty downgrade function, making it irreversible. While outside the scope of this PR's diff, I recommend implementing downgrade logic in migrations for better database schema management.
2 participants
Description
Explain the changes or enhancements you are proposing with this pull request.
This PR adds a new test that runs all migrations in both postgres and mariadb, when migrations change.
Checklist
Please check all that apply.