New endpoints to fetch all IDs by gantoine · Pull Request #2921 · rommapp/romm

gantoine · 2026-01-19T03:52:05Z

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

These are high-performance endpoints that simply return a list of IDs for some objects, without a) fetching all fields and b) going through pydantic to populate the models.

Checklist
^{Please check all that apply.}

I've tested the changes locally
I've updated relevant comments
I've assigned reviewers for this PR
I've added unit tests that cover the changes

gemini-code-assist · 2026-01-19T03:52:32Z

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the API by introducing a suite of new endpoints designed to efficiently retrieve lists of identifiers for various resource types, such as collections, firmware, platforms, ROMs, saves, states, and users. This change improves client-side data fetching by allowing applications to request only the IDs they need, reducing payload size and database load. The underlying database query logic has been optimized to support this partial data retrieval, ensuring better performance.

Highlights

New Identifier Endpoints: Introduced dedicated /identifiers endpoints across various resource types (collections, firmware, platforms, ROMs, saves, states, and users) to efficiently retrieve lists of their respective IDs.
Database Query Optimization: Enhanced underlying database handler methods to accept an only_fields parameter, enabling SQLAlchemy's load_only option for more efficient retrieval of specific columns, primarily for the new identifier endpoints.
Code Clean-up and Consistency: Removed redundant db_rom_handler imports from within functions in backend/endpoints/rom.py and updated a comment in backend/handler/metadata/igdb_handler.py for clarity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-01-19T03:54:39Z

Test Results

703 tests 702 ✅ 1m 28s ⏱️
1 suites 1 💤
1 files 0 ❌

Results for commit 67efe62.

♻️ This comment has been updated with latest results.

github-actions · 2026-01-19T03:54:41Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12330	7989	65%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
backend/endpoints/collections.py	30%	🟢
backend/endpoints/firmware.py	29%	🟢
backend/endpoints/platform.py	56%	🟢
backend/endpoints/responses/collection.py	96%	🟢
backend/endpoints/rom.py	45%	🟢
backend/endpoints/saves.py	31%	🟢
backend/endpoints/states.py	31%	🟢
backend/endpoints/user.py	59%	🟢
backend/handler/database/collections_handler.py	45%	🟢
backend/handler/database/firmware_handler.py	58%	🟢
backend/handler/database/platforms_handler.py	86%	🟢
backend/handler/database/roms_handler.py	55%	🟢
backend/handler/database/saves_handler.py	90%	🟢
backend/handler/database/states_handler.py	90%	🟢
backend/handler/database/users_handler.py	90%	🟢
backend/handler/metadata/igdb_handler.py	36%	🟢
TOTAL	58%	🟢

updated for commit: 67efe62 by action🐍

BrandonKowalski · 2026-01-19T03:54:42Z

Damn. This caused more work than anticipated. Thanks for doing this! ❤️

gemini-code-assist

Code Review

The pull request introduces new endpoints to fetch identifiers for various entities (collections, firmware, platforms, ROMs, saves, states, and users). It also refactors the corresponding database handlers to accept an only_fields parameter, optimizing queries by loading only necessary columns. This is a good approach for improving efficiency. Additionally, some minor cleanup of local imports in backend/endpoints/rom.py and a comment update in backend/handler/metadata/igdb_handler.py were made.

backend/endpoints/collections.py

gantoine · 2026-01-19T14:17:12Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces several new /identifiers endpoints across various resources to efficiently fetch only the IDs. This is a great performance enhancement. The implementation is supported by adding an only_fields parameter to the corresponding database handler methods, which leverages SQLAlchemy's load_only feature.

My review focuses on further improving the performance of these new endpoints. I've identified a few areas where database queries can be made more efficient by avoiding unnecessary data loading and moving filtering logic from the application to the database. These changes will ensure the new endpoints are as fast and scalable as possible.

backend/endpoints/collections.py

backend/handler/database/collections_handler.py

backend/handler/database/platforms_handler.py

gantoine · 2026-01-19T14:48:06Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces new high-performance endpoints to fetch resource identifiers, which is a great addition for improving frontend performance. The changes are well-implemented by adding an only_fields parameter to the database handlers to limit the data fetched from the database. I've found a couple of areas for improvement related to performance and code redundancy in the new and existing endpoints, which I've detailed in the comments. Specifically, one of the new identifier endpoints can be made more efficient, and an existing endpoint has some redundant filtering logic. Overall, this is a solid contribution that improves the API's performance. Addressing the suggested changes will make it even better.

backend/endpoints/collections.py

gantoine added 4 commits January 18, 2026 21:26

DB functions accept list of params

54bfb3f

add endpoints for identifiers

3ccc14d

manual cleanup

bddb7bd

final manual clenaup

6eb8884

gantoine mentioned this pull request Jan 19, 2026

[ROMM-2919] Return All IDs Endpoints #2920

Closed

4 tasks

manual fixes

9abbcca

gemini-code-assist bot reviewed Jan 19, 2026

View reviewed changes

backend/endpoints/collections.py Outdated Show resolved Hide resolved

backend/endpoints/collections.py Show resolved Hide resolved

fix bot review

6b1eda0

BrandonKowalski mentioned this pull request Jan 19, 2026

Deleted Games / Platforms / Collections are not removed from cache rommapp/grout#83

Closed

gemini-code-assist bot reviewed Jan 19, 2026

View reviewed changes

backend/endpoints/collections.py Show resolved Hide resolved

backend/handler/database/collections_handler.py Show resolved Hide resolved

backend/handler/database/platforms_handler.py Show resolved Hide resolved

tweak some db code

e9b6fa2

gantoine marked this pull request as ready for review January 19, 2026 14:59

gemini-code-assist bot reviewed Jan 19, 2026

View reviewed changes

backend/endpoints/collections.py Outdated Show resolved Hide resolved

backend/endpoints/collections.py Show resolved Hide resolved

gantoine added 2 commits January 19, 2026 10:11

last fix

c9879b7

Merge branch 'master' into only-ids-param

67efe62

gantoine merged commit 2052ca6 into master Jan 28, 2026
8 checks passed

gantoine deleted the only-ids-param branch January 28, 2026 19:55

Uh oh!

Conversation

gantoine commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

Uh oh!

BrandonKowalski commented Jan 19, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gantoine commented Jan 19, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gantoine commented Jan 19, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gantoine commented Jan 19, 2026 •

edited

Loading

github-actions bot commented Jan 19, 2026 •

edited

Loading

github-actions bot commented Jan 19, 2026 •

edited

Loading