Skip to content

[ROMM-2889] Add media to update_config_file#2897

Merged
gantoine merged 2 commits intomasterfrom
romm-2889
Jan 12, 2026
Merged

[ROMM-2889] Add media to update_config_file#2897
gantoine merged 2 commits intomasterfrom
romm-2889

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 12, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2889

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 12, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the SCAN_MEDIA setting into the system's configuration update mechanism. This change ensures that the application correctly saves and manages the media-related scanning preferences, aligning the configuration file with the expected operational parameters.

Highlights

  • Configuration Update: The _update_config_file method in backend/config/config_manager.py has been updated to include SCAN_MEDIA in the configuration dictionary. This ensures that the media scanning preference is persisted.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the SCAN_MEDIA configuration to be persisted in config.yml, addressing the core issue. The change itself is correct. However, the pull request appears to be incomplete. As noted in the specific review comment, the API response model has not been updated to include this new configuration setting, which will prevent it from being exposed to the frontend. Please see the detailed comment for the required changes to make this feature fully functional.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Test Results

703 tests  ±0   702 ✅ ±0   1m 29s ⏱️ +2s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 742a7c5. ± Comparison against base commit a0d5307.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12176 7904 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/config/config_manager.py 54% 🟢
backend/endpoints/configs.py 39% 🟢
backend/endpoints/responses/config.py 100% 🟢
TOTAL 64% 🟢

updated for commit: 742a7c5 by action🐍

@gantoine gantoine merged commit 751aff5 into master Jan 12, 2026
8 checks passed
@gantoine gantoine deleted the romm-2889 branch January 12, 2026 15:21
@mglakner
Copy link
Copy Markdown

mglakner commented Jan 12, 2026 •
edited
Loading

I'm the writer of issue 2889 I just did this again yesterday. Edited my config.yml and added scan: media: and then changed something in library management on the webUI and it takes out my scan: media: out of my config.yml. This isn't solved for me.

@gantoine
Copy link
Copy Markdown
Member Author

gantoine commented Jan 12, 2026

@mglakner we uh, need to release a new version before it'll be fixed on your server

@mglakner
Copy link
Copy Markdown

mglakner commented Jan 12, 2026

@mglakner we uh, need to release a new version before it'll be fixed on your server

Apologies, I interpreted this as being solved and vanilla. I'll wait for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Changing Config.yml when editing Library Management Config

2 participants

@gantoine @mglakner