Skip to content

[HOTFIX] Check if gamelist metadata source selected before populating cache#2865

Merged
gantoine merged 1 commit intomasterfrom
check-gamelist-enabled-populate-cache
Jan 10, 2026
Merged

[HOTFIX] Check if gamelist metadata source selected before populating cache#2865
gantoine merged 1 commit intomasterfrom
check-gamelist-enabled-populate-cache

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 3, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

No point in populating the cache if gamelist handler isn't being used during the scan...

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gantoine gantoine requested a review from zurdi15 January 3, 2026 23:22
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 3, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This hotfix refines the scanning process by introducing a conditional check for gamelist.xml cache population. It ensures that the cache is only built when the gamelist metadata source is actively selected, thereby optimizing resource usage and improving scan efficiency by avoiding redundant operations.

Highlights

  • Optimized Gamelist Cache Population: The system will now only populate the gamelist.xml cache during a scan if the MetadataSource.GAMELIST option is explicitly selected, preventing unnecessary processing when this source is not in use.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a small but effective optimization. By checking if gamelist is a selected metadata source before populating the cache, it avoids unnecessary processing during scans. The change is well-implemented and correctly uses the MetadataSource enum. This is a good hotfix that improves efficiency.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 3, 2026

Test Results

702 tests  ±0   701 ✅ ±0   1m 26s ⏱️ -1s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6878fcc. ± Comparison against base commit 1019274.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 3, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12121 7885 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/endpoints/sockets/scan.py 26% 🟢
TOTAL 26% 🟢

updated for commit: 6878fcc by action🐍

@gantoine gantoine merged commit 6e5beb0 into master Jan 10, 2026
8 checks passed
@gantoine gantoine deleted the check-gamelist-enabled-populate-cache branch January 10, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zurdi15 zurdi15 Awaiting requested review from zurdi15

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gantoine