Skip to content

[ROMM-2808] Stop filtering nsfw games from search results#2852

Merged
gantoine merged 1 commit intomasterfrom
romm-2808
Jan 10, 2026
Merged

[ROMM-2808] Stop filtering nsfw games from search results#2852
gantoine merged 1 commit intomasterfrom
romm-2808

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 2, 2026 •
edited
Loading

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2808

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 2, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where NSFW games were being filtered out of search results and individual game lookups. By modifying a single API parameter, the change ensures that all games, regardless of their content rating, are now discoverable and retrievable through the system's API, aligning with the intent to stop this specific content filtering.

Highlights

  • NSFW Game Filtering Disabled: The pull request disables the filtering of NSFW (Not Safe For Work) games from search results and when retrieving games by ID.
  • API Parameter Change: The 'filter' parameter in API calls to the search URL has been changed from 'true' to 'false' in both the 'search_games' and 'get_rom_by_id' functions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables NSFW content filtering from Flashpoint search results by changing the filter API parameter from true to false in search_games and get_rom_by_id. The change is correct according to the PR's goal. My review includes a suggestion to make this behavior configurable to provide more flexibility for users, and to address the code duplication of the hardcoded value.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 2, 2026

Test Results

702 tests  ±0   701 ✅ ±0   1m 29s ⏱️ +6s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fa84ecf. ± Comparison against base commit 6b600dd.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 2, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12120 7885 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/metadata/flashpoint_handler.py 46% 🟢
TOTAL 46% 🟢

updated for commit: fa84ecf by action🐍

@gantoine gantoine requested a review from zurdi15 January 3, 2026 22:45
@gantoine gantoine merged commit b8c2998 into master Jan 10, 2026
8 checks passed
@gantoine gantoine deleted the romm-2808 branch January 10, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zurdi15 zurdi15 Awaiting requested review from zurdi15

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Flashpoint API filtering NSFW results

1 participant

@gantoine