Skip to content

[ROMM-2844] Use webp images for game covers in list view#2845

Merged
gantoine merged 2 commits intomasterfrom
romm-2844
Jan 2, 2026
Merged

[ROMM-2844] Use webp images for game covers in list view#2845
gantoine merged 2 commits intomasterfrom
romm-2844

Conversation

@gantoine
Copy link
Copy Markdown
Member

@gantoine gantoine commented Jan 2, 2026

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2844

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gantoine gantoine requested a review from zurdi15 January 2, 2026 15:58
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 2, 2026

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the display of game covers in list views by introducing support for the WebP image format. By conditionally serving WebP images, the system can achieve faster loading times and more efficient resource usage. Additionally, the changes refine how cover art is displayed, incorporating animation logic and improving the visual feedback during image loading.

Highlights

  • WebP Image Support: Implemented conditional support for WebP image format for game covers in list views, aiming to improve loading performance and reduce bandwidth.
  • Dynamic Image Source Selection: Introduced a computed property smallCover that dynamically selects the appropriate image source, prioritizing WebP if enabled via a feature flag, or using a box art style cover.
  • Enhanced Image Loading UI: Replaced the previous error fallback for image loading with a Skeleton placeholder component, providing a smoother user experience during image loading.
  • Integration with Game Animation: Integrated useGameAnimation to apply specific styling (cover/contain) to game cover images based on whether a box art style cover is present.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the RAvatar component to use .webp images for game covers when available, which is a great optimization. My review focuses on some regressions introduced in the template part of the component. I've identified missing accessibility attributes and error handling for image loading, and a missing template ref. I've provided a single comment with a code suggestion that addresses all these points to improve the component's robustness and accessibility.

@zurdi15
Copy link
Copy Markdown
Member

zurdi15 commented Jan 2, 2026

What if the scheduled task is not enabled but ran at least once manually?

@Ronald-Diemicke
Copy link
Copy Markdown

Ronald-Diemicke commented Jan 2, 2026 •
edited
Loading

What if the scheduled task is not enabled but ran at least once manually?

IMHO - that might be a different issue entirely because I noticed I had to enable the task - without enabling it, I couldn't run it manually nor would it run scheduled.

I'd argue managing this via a switch is bad sub-optimal overall and 'yet another' reason that the conversion should almost be forced (like I was mentioning in discord) so that you can predictably use the best format instead of making this via configuration, it could be via convention.

@gantoine gantoine merged commit a8096e1 into master Jan 2, 2026
7 checks passed
@gantoine gantoine deleted the romm-2844 branch January 2, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zurdi15 zurdi15 Awaiting requested review from zurdi15

2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@Ronald-Diemicke Ronald-Diemicke Ronald-Diemicke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] List view always requests PNG even when WebP is available and downloaded

3 participants

@gantoine @zurdi15 @Ronald-Diemicke