Conversation
gantoine
changed the title
gantoine
changed the title
Summary of ChangesHello @gantoine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the search term generation logic for external metadata services, specifically HowLongToBeat and Launchbox. It introduces an additional string replacement rule to handle cases where a hyphen might not be preceded by a space, ensuring that game titles are consistently formatted to match the conventions of these services. This enhancement aims to improve the success rate of metadata lookups by accommodating more variations in file naming. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue by replacing hyphens with colons in more edge cases for HLTB and Launchbox handlers. The implementation adds a chained .replace() call in both handlers. My review suggests using a regular expression to make this logic more concise and robust, which would also handle various whitespace characters. I've also pointed out that the comments explaining the replacement should be updated to reflect the new logic.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request addresses an edge case in parsing game names by replacing more variations of hyphens with colons in the HLTB and LaunchBox handlers. The change uses a regular expression to handle cases like - and - .
My main feedback is regarding code duplication. The new regular expression DASH_COLON_REGEX is defined in both hltb_handler.py and launchbox_handler.py. To improve maintainability, this constant should be defined in a shared location, such as the base_handler.py file, from which both handlers inherit. I've left specific comments on where this can be improved.
2 participants
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2824
Checklist
Please check all that apply.