Conversation
Summary of ChangesHello @matthew-pye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the game installation process by integrating support for 7z archive extraction. It provides users with the option to leverage an external 7z executable, which has demonstrated superior performance over the current SharpCompress method for large archives. The change includes new configuration options within the application's settings, allowing users to enable this feature and define the path to their 7z installation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a great feature by adding support for 7z extraction, which offers a significant performance improvement. The implementation is mostly solid, but I've identified a critical issue where a failed extraction doesn't correctly abort the installation process, potentially leaving the game in a broken state. I've also noted a few medium-severity issues related to a case-sensitive file check and opportunities to improve data binding practices in the settings view for better maintainability. My review includes specific suggestions to address these points.
|
Looks good! |
There was a problem hiding this comment.
Code Review
This pull request introduces an optional 7z extraction method, offering a significant performance improvement. No security vulnerabilities were found. Suggestions have been provided to enhance the robustness of the 7z path validation and to improve the clarity and maintainability of the XAML code for the new settings.
3 participants
Added 7z extraction
Performance Difference (1.10 GiB Multi-File ROM) :
31-01 15:46:19.474|INFO |RomM#RomMInstallController:7z extraction took 11487333 ticks31-01 15:46:21.669|INFO |RomM#RomMInstallController:SharpCompress extraction took 21966187 ticksSometime down the line maybe switching to using the 7z.libs nuGet package instead of relying on the 7z.exe might be a better especially once Playnite gets a linux version.
Sorry for spamming pull requests